From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932315AbdJZBJw (ORCPT ); Wed, 25 Oct 2017 21:09:52 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:50998 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932198AbdJZBJv (ORCPT ); Wed, 25 Oct 2017 21:09:51 -0400 X-Google-Smtp-Source: ABhQp+SW+Z/eRz0/4HbCUjQYunkw7JepWhtbAtvZr3pmIefAHc6/dGVhz+I1ulJJlg81PL/pjwXQJQ== Date: Wed, 25 Oct 2017 18:09:47 -0700 From: Brian Norris To: Sean Paul Cc: Nickey Yang , mark.yao@rock-chips.com, robh+dt@kernel.org, heiko@sntech.de, mark.rutland@arm.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, hl@rock-chips.com, zyw@rock-chips.comg, xbl@rock-chips.com, Kristian Kristensen , Archit Taneja , Philippe CORNU Subject: Re: [PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting Message-ID: <20171026010946.GA33225@google.com> References: <1508903463-7254-1-git-send-email-nickey.yang@rock-chips.com> <1508903463-7254-3-git-send-email-nickey.yang@rock-chips.com> <20171025075719.4tt7lomec5x7guon@art_vandelay> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171025075719.4tt7lomec5x7guon@art_vandelay> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 25, 2017 at 03:57:19AM -0400, Sean Paul wrote: > Archit asked a question about moving to > dw-mipi-dsi That question made me think though: this approach seems backwards. It seems like someone did copy/paste/fork, and then we're asking the authors of the original driver to un-fork? It seems like this should happen the other way around -- those trying to support a new incarnation should have looked to try to abstract the original driver for their uses first. IIUC, that's exactly what Rockchip did for much of their Analogix eDP code -- they reworked the Exynos DP driver to split common Analogix code from any Exynos-specific bits. And actually, the current stuff in drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c is completely unused. It exports some functions, but I see no users of it. Is that intended? Is somebody already working on refactoring existing Rockchip code to use this? Brian