From: Michal Hocko <mhocko@kernel.org>
To: Yang Shi <yang.s@alibaba-inc.com>
Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: oom: dump single excessive slab cache when oom
Date: Thu, 26 Oct 2017 19:14:14 +0200 [thread overview]
Message-ID: <20171026171414.mwetwu43hnxavwfn@dhcp22.suse.cz> (raw)
In-Reply-To: <20171026162701.re4lclnqkngczpcl@dhcp22.suse.cz>
On Thu 26-10-17 18:27:01, Michal Hocko wrote:
> On Fri 27-10-17 00:15:17, Yang Shi wrote:
> >
> >
> > On 10/26/17 7:53 AM, Michal Hocko wrote:
> > > On Thu 26-10-17 06:49:00, Yang Shi wrote:
> > > > Per the discussion with David [1], it looks more reasonable to just dump
> > >
> > > Please try to avoid external references in the changelog as much as
> > > possible.
> >
> > OK.
> >
> > >
> > > > the single excessive slab cache instead of dumping all slab caches when
> > > > oom.
> > >
> > > You meant to say
> > > "to just dump all slab caches which excess 10% of the total memory."
> > >
> > > While we are at it. Abusing calc_mem_size seems to be rather clumsy and
> > > tt is not nodemask aware so you the whole thing is dubious for NUMA
> > > constrained OOMs.
> >
> > Since we just need the total memory size of the node for NUMA constrained
> > OOM, we should be able to use show_mem_node_skip() to bring in nodemask.
>
> yes
to be more specific. This would work for the total number of pages
calculation. This is still not enough, though. You would also have to
filter slabs per numa node and this is getting more and more complicated
for a marginal improvement.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-10-26 17:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 22:48 [PATCH 0/2 -mmotm] oom: show single slab cache in oom whose size > 10% of total system memory Yang Shi
2017-10-25 22:48 ` [PATCH 1/2] mm: extract common code for calculating total memory size Yang Shi
2017-10-27 10:00 ` Christopher Lameter
2017-10-27 16:51 ` Yang Shi
2017-10-31 16:45 ` Yang Shi
2017-10-25 22:49 ` [PATCH 2/2] mm: oom: dump single excessive slab cache when oom Yang Shi
2017-10-26 14:53 ` Michal Hocko
2017-10-26 16:15 ` Yang Shi
2017-10-26 16:27 ` Michal Hocko
2017-10-26 17:14 ` Michal Hocko [this message]
2017-10-31 16:47 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026171414.mwetwu43hnxavwfn@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=yang.s@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).