linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	cmetcalf@mellanox.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, torvalds@linux-foundation.org, hpa@zytor.com,
	riel@redhat.com, cl@linux.com, efault@gmx.de,
	kernellwp@gmail.com, paulmck@linux.vnet.ibm.com,
	lcapitulino@redhat.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched/isolation: Document the isolcpus= flags
Date: Fri, 27 Oct 2017 19:06:32 +0200	[thread overview]
Message-ID: <20171027170632.mxwfe5hd4cmlguvb@gmail.com> (raw)
In-Reply-To: <CAFTL4hxLPZGPgwVnoh9SrEicymA=XSVLuwCwLQiohWYOha93gQ@mail.gmail.com>


* Frederic Weisbecker <frederic@kernel.org> wrote:

> 2017-10-27 15:58 UTC+02:00, Peter Zijlstra <peterz@infradead.org>:
> > On Fri, Oct 27, 2017 at 05:06:25AM -0700, tip-bot for Frederic Weisbecker
> > wrote:
> >> +	isolcpus=	[KNL,SMP] Isolate a given set of CPUs from disturbance.
> >> +			Format: [flag-list,]<cpu-list>
> >> +
> >> +			Specify one or more CPUs to isolate from disturbances
> >> +			specified in the flag list (default: domain):
> >> +
> >> +			nohz
> >> +			  Disable the tick when a single task runs.
> >> +			domain
> >> +			  Isolate from the general SMP balancing and scheduling
> >> +			  algorithms. This option is the preferred way to isolate
> >> +			  CPUs from tasks.
> >
> > I _strongly_ object to this statement, isolcpus is _not_ the preferred
> > way, cpusets are.
> >
> > And yes, while cpusets suffers some problems, we _should_ really fix
> > those and not promote this piece of shit isolcpus crap.
> 
> I definitely agree with that so your position is a relief :-) This
> patch only indented the existing parameter documentation so fixing its
> content was beyond its scope. I'll send a patch to correct the text.

Since it was the last commit in tip:sched/core that was pushed out just hours ago 
I zapped that last commit, please send an updated patch which we can apply and get 
a clean series.

Thanks,

	Ingo

  reply	other threads:[~2017-10-27 17:06 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27  2:42 [GIT PULL] Housekeeping subsystem v6 Frederic Weisbecker
2017-10-27  2:42 ` [PATCH 01/12] housekeeping: Move housekeeping related code to its own file Frederic Weisbecker
2017-10-27 12:01   ` [tip:sched/core] sched/isolation: " tip-bot for Frederic Weisbecker
2017-10-27  2:42 ` [PATCH 02/12] watchdog: Use housekeeping_cpumask() instead of ad-hoc version Frederic Weisbecker
2017-10-27 12:02   ` [tip:sched/core] sched/isolation, " tip-bot for Frederic Weisbecker
2017-10-27  2:42 ` [PATCH 03/12] housekeeping: Provide a dynamic off-case to housekeeping_any_cpu() Frederic Weisbecker
2017-10-27 12:02   ` [tip:sched/core] sched/isolation: " tip-bot for Frederic Weisbecker
2017-10-27  2:42 ` [PATCH 04/12] housekeeping: Make housekeeping cpumask private Frederic Weisbecker
2017-10-27 12:03   ` [tip:sched/core] sched/isolation: Make the " tip-bot for Frederic Weisbecker
2017-10-27  2:42 ` [PATCH 05/12] housekeeping: Use its own static key Frederic Weisbecker
2017-10-27 12:03   ` [tip:sched/core] sched/isolation: " tip-bot for Frederic Weisbecker
2017-10-27  2:42 ` [PATCH 06/12] housekeeping: Rename is_housekeeping_cpu to housekeeping_cpu Frederic Weisbecker
2017-10-27 12:03   ` [tip:sched/core] sched/isolation: Rename is_housekeeping_cpu() to housekeeping_cpu() tip-bot for Frederic Weisbecker
2017-10-27  2:42 ` [PATCH 07/12] housekeeping: Move it under its own config, independent from NO_HZ Frederic Weisbecker
2017-10-27 12:04   ` [tip:sched/core] sched/isolation: Split out new CONFIG_CPU_ISOLATION=y config from CONFIG_NO_HZ_FULL tip-bot for Frederic Weisbecker
2017-10-27  2:42 ` [PATCH 08/12] housekeeping: Introduce housekeeping flags Frederic Weisbecker
2017-10-27 12:04   ` [tip:sched/core] sched/isolation: " tip-bot for Frederic Weisbecker
2017-10-27  2:42 ` [PATCH 09/12] housekeeping: Handle the nohz_full= parameter Frederic Weisbecker
2017-10-27 12:05   ` [tip:sched/core] sched/isolation: " tip-bot for Frederic Weisbecker
2017-10-27  2:42 ` [PATCH 10/12] housekeeping: Move isolcpus to housekeeping Frederic Weisbecker
2017-10-27 12:05   ` [tip:sched/core] sched/isolation: Move isolcpus= handling to the housekeeping code tip-bot for Frederic Weisbecker
2017-10-27  2:42 ` [PATCH 11/12] housekeeping: Add basic isolcpus flags Frederic Weisbecker
2017-10-27 12:05   ` [tip:sched/core] sched/isolation: " tip-bot for Frederic Weisbecker
2017-10-27  2:42 ` [PATCH 12/12] housekeeping: Document " Frederic Weisbecker
2017-10-27 12:06   ` [tip:sched/core] sched/isolation: Document the isolcpus= flags tip-bot for Frederic Weisbecker
2017-10-27 13:58     ` Peter Zijlstra
2017-10-27 14:36       ` Frederic Weisbecker
2017-10-27 17:06         ` Ingo Molnar [this message]
2017-10-27 17:33           ` Frederic Weisbecker
2017-10-27 18:21             ` Ingo Molnar
2017-10-27 18:39               ` Frederic Weisbecker
2017-10-27 19:04                 ` Ingo Molnar
2017-10-27 14:38       ` Mike Galbraith
2017-10-30 15:48       ` Christopher Lameter
2017-10-30 16:11         ` Peter Zijlstra
2017-10-30 16:30           ` Christopher Lameter
2017-10-30 16:58             ` Peter Zijlstra
2017-10-30 16:56           ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171027170632.mxwfe5hd4cmlguvb@gmail.com \
    --to=mingo@kernel.org \
    --cc=cl@linux.com \
    --cc=cmetcalf@mellanox.com \
    --cc=efault@gmx.de \
    --cc=frederic@kernel.org \
    --cc=hpa@zytor.com \
    --cc=kernellwp@gmail.com \
    --cc=lcapitulino@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).