Hi,

On Sat, Oct 21, 2017 at 10:08:40AM -0700, Guenter Roeck wrote:
> On 10/18/2017 10:01 AM, Andrey Smirnov wrote:
> > Using devres infrastructure it is possible to wirte a serdev driver
> 
> s/wirte/write/
> 
> otherwise
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

> > that doesn't have any code that needs to be called as a part of
> > .remove. Add code to make .remove optional.
> > 
> > Cc: linux-kernel@vger.kernel.org
> > Cc: linux-serial@vger.kernel.org
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: cphealy@gmail.com
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Pavel Machek <pavel@ucw.cz>
> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Cc: Johan Hovold <johan@kernel.org>
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > ---
> >   drivers/tty/serdev/core.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
> > index c68fb3a8ea1c..f500f6a2ca88 100644
> > --- a/drivers/tty/serdev/core.c
> > +++ b/drivers/tty/serdev/core.c
> > @@ -252,8 +252,8 @@ static int serdev_drv_probe(struct device *dev)
> >   static int serdev_drv_remove(struct device *dev)
> >   {
> >   	const struct serdev_device_driver *sdrv = to_serdev_device_driver(dev->driver);
> > -
> > -	sdrv->remove(to_serdev_device(dev));
> > +	if (sdrv->remove)
> > +		sdrv->remove(to_serdev_device(dev));
> >   	return 0;
> >   }
> > 
>