From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752565AbdJ0TYZ (ORCPT <rfc822;w@1wt.eu>);
        Fri, 27 Oct 2017 15:24:25 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:53027 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750998AbdJ0TYV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Oct 2017 15:24:21 -0400
X-Google-Smtp-Source: ABhQp+TnXjH0loaMOypHX0c+DtUQVRhUCqTyFYe0d7WMHSVgT36iOGMVp6Wf8/Wd/DyMNgTpRZmz5Q==
Date: Fri, 27 Oct 2017 21:24:17 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Craig Bergstrom <craigb@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Sander Eikelenboom <linux@eikelenboom.it>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Fengguang Wu <fengguang.wu@intel.com>, wfg@linux.intel.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        LKP <lkp@01.org>
Subject: Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical
 addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!
Message-ID: <20171027192417.d2x4cy6ra7fghjzw@gmail.com>
References: <CAOJUGyfTM2J-P29yPhUx2A2SDjA0rv972SE0hmbMHonthMd_bQ@mail.gmail.com>
 <440615a7-6cc0-a607-ce7c-22a34b69e8fe@eikelenboom.it>
 <1d203c07-0595-a33a-620b-c51eea9721d1@eikelenboom.it>
 <8721eeac-a644-e815-55e9-5f01956dd22a@eikelenboom.it>
 <CAOJUGye8nXL-J9oArLLMFz-RPRdKFe6EgqtYPSr5kcWoH2EodQ@mail.gmail.com>
 <20171026163911.dnovh4zaik5qumtt@gmail.com>
 <CAOJUGycO494NcvJk89MMub9Tbrj6FUoSNN4SOci7NgJRKq7v=A@mail.gmail.com>
 <20171026190229.zt743ooxvjsukmis@gmail.com>
 <CA+55aFw_7PFDnTRO1C6gH99vdY+w77Rp_8Ns8krSjxmxSs6mVw@mail.gmail.com>
 <CAOJUGyfZxbhyMuh3zE77R3b30RF3Xi7jB4_mmSjhWtFQhVc5jQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOJUGyfZxbhyMuh3zE77R3b30RF3Xi7jB4_mmSjhWtFQhVc5jQ@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Craig Bergstrom <craigb@google.com> wrote:

> Reverting seems like the right approach at the moment.  My apologies
> for the breakage so late the in the cycle.

Note that there's no need for you to apologize and you carry exactly zero amount 
of blame for the late-cycle breakage: it was my decision to send it to Linus so 
quickly, you never asked for it to be sent upstream on such a short notice.

( Classic "patch makes sense, looks good, other arches ar doing this too, and I 
  tested it myself too on multiple systems, so it must be obviously fine for 
  everyone" moment. )

Your change still makes sense from a robustness POV, so please send it again with 
the suggested fixes - and I'll be more careful with the upstream merge this time.

Thanks,

	Ingo