From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751399AbdJ1N7y (ORCPT ); Sat, 28 Oct 2017 09:59:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:48363 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751268AbdJ1N7x (ORCPT ); Sat, 28 Oct 2017 09:59:53 -0400 Date: Sat, 28 Oct 2017 06:58:54 -0700 From: Davidlohr Bueso To: Hou Tao Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, jbaron@akamai.com, oleg@redhat.com, koct9i@gmail.com Subject: Re: [RFC][PATCH 1/8] epoll: remove epmutex from ep_free() & eventpoll_release_file() Message-ID: <20171028135854.mpdcngbkozssucrs@linux-n805> References: <1509195507-29037-1-git-send-email-houtao1@huawei.com> <1509195507-29037-2-git-send-email-houtao1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1509195507-29037-2-git-send-email-houtao1@huawei.com> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 28 Oct 2017, Hou Tao wrote: >Remove the global epmutex from ep_free() and eventpoll_release_file(). >In the later patches, we will add locks with a smaller granularity >to serve the same purposes of epmutex. > >Signed-off-by: Hou Tao >--- > fs/eventpoll.c | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/fs/eventpoll.c b/fs/eventpoll.c >index 2fabd19..26ab0c5 100644 >--- a/fs/eventpoll.c >+++ b/fs/eventpoll.c >@@ -835,7 +835,6 @@ static void ep_free(struct eventpoll *ep) > * anymore. The only hit might come from eventpoll_release_file() but > * holding "epmutex" is sufficient here. > */ ^^ What about this comment (and the equivalent one in eventpoll_release_file()? >- mutex_lock(&epmutex); ...even if you fix it in a later patch, this patch breaks bisection. Now we just race between ep_free() and eventpoll_release_file(). This patch should be folded in, no? Thanks, Davidlohr