From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932530AbdJ3KIo (ORCPT ); Mon, 30 Oct 2017 06:08:44 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:50597 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751772AbdJ3KIm (ORCPT ); Mon, 30 Oct 2017 06:08:42 -0400 X-Google-Smtp-Source: ABhQp+R5+Axt9RumD8xPvxLTe625v0S4mqdwOekBBoK1lIwstQ6dk1NJLqFGLJ7ImeoaFsFurbQWHA== Date: Mon, 30 Oct 2017 11:08:38 +0100 From: Daniel Vetter To: Kees Cook Cc: Patrik Jakobsson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: gma500: Convert timers to use timer_setup() Message-ID: <20171030100838.lvjxy3o6q227kjsn@phenom.ffwll.local> Mail-Followup-To: Kees Cook , Patrik Jakobsson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20171024151609.GA104501@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171024151609.GA104501@beast> X-Operating-System: Linux phenom 4.12.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 24, 2017 at 08:16:09AM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Patrik Jakobsson > Cc: David Airlie > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Kees Cook Do you expect drm folks to apply this, or is this part of a larger refactoring? A notch more context in the commit message would help ... -Daniel > --- > drivers/gpu/drm/gma500/psb_lid.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/psb_lid.c b/drivers/gpu/drm/gma500/psb_lid.c > index 1d2ebb5e530f..be6dda58fcae 100644 > --- a/drivers/gpu/drm/gma500/psb_lid.c > +++ b/drivers/gpu/drm/gma500/psb_lid.c > @@ -23,9 +23,9 @@ > #include "psb_intel_reg.h" > #include > > -static void psb_lid_timer_func(unsigned long data) > +static void psb_lid_timer_func(struct timer_list *t) > { > - struct drm_psb_private * dev_priv = (struct drm_psb_private *)data; > + struct drm_psb_private *dev_priv = from_timer(dev_priv, t, lid_timer); > struct drm_device *dev = (struct drm_device *)dev_priv->dev; > struct timer_list *lid_timer = &dev_priv->lid_timer; > unsigned long irq_flags; > @@ -77,10 +77,8 @@ void psb_lid_timer_init(struct drm_psb_private *dev_priv) > spin_lock_init(&dev_priv->lid_lock); > spin_lock_irqsave(&dev_priv->lid_lock, irq_flags); > > - init_timer(lid_timer); > + timer_setup(lid_timer, psb_lid_timer_func, 0); > > - lid_timer->data = (unsigned long)dev_priv; > - lid_timer->function = psb_lid_timer_func; > lid_timer->expires = jiffies + PSB_LID_DELAY; > > add_timer(lid_timer); > -- > 2.7.4 > > > -- > Kees Cook > Pixel Security > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch