From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422AbdJ3NgH (ORCPT ); Mon, 30 Oct 2017 09:36:07 -0400 Received: from merlin.infradead.org ([205.233.59.134]:60476 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751561AbdJ3NgG (ORCPT ); Mon, 30 Oct 2017 09:36:06 -0400 Date: Mon, 30 Oct 2017 14:35:43 +0100 From: Peter Zijlstra To: Morten Rasmussen Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, tj@kernel.org, josef@toxicpanda.com, torvalds@linux-foundation.org, vincent.guittot@linaro.org, efault@gmx.de, pjt@google.com, clm@fb.com, dietmar.eggemann@arm.com, bsegall@google.com, yuyang.du@intel.com Subject: Re: [PATCH -v2 12/18] sched/fair: Rewrite PELT migration propagation Message-ID: <20171030133543.6n5lj6ml7khdds4j@hirez.programming.kicks-ass.net> References: <20170901132059.342024223@infradead.org> <20170901132748.580255511@infradead.org> <20171009080856.GB24129@e105550-lin.cambridge.arm.com> <20171009094517.wfovc5b2dpbazta4@hirez.programming.kicks-ass.net> <20171018124523.GA27508@e105550-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171018124523.GA27508@e105550-lin.cambridge.arm.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2017 at 01:45:25PM +0100, Morten Rasmussen wrote: > > > > + * Basically (4) but in differential form: > > > > + * > > > > + * d(runnable_avg) += se->avg.load_avg / se->load.weight > > > > + * (5) > > > > + * ge->avg.load_avg += ge->load.weight * d(runnable_avg) > > > > And this all has runnable again, and so should make sense. > > I'm afraid I don't quite get why (5) is correct. It might be related to > the issues Vincent already pointed out. Yeah; I think so... Let me stare at his latest -- which still doesn't update this comment.. :/