From: Ingo Molnar <mingo@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Shile Zhang <shile.zhang@nokia.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Nick Desaulniers <nick.desaulniers@gmail.com>,
Douglas Anderson <dianders@chromium.org>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH v2] sched/sysctl: Fix attributes of some extern declarations
Date: Tue, 31 Oct 2017 10:57:58 +0100 [thread overview]
Message-ID: <20171031095758.wsgbrsdz7hzn5o2n@gmail.com> (raw)
In-Reply-To: <20171030180816.170850-1-mka@chromium.org>
* Matthias Kaehlcke <mka@chromium.org> wrote:
> The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate
> and sysctl_sched_time_avg includes the attribute const_debug. This
> attribute is not part of the extern declaration of these variables in
> include/linux/sched/sysctl.h, as a result clang generates warnings like
> this:
>
> kernel/sched/sched.h:1618:33: warning: section attribute is specified on
> redeclared variable [-Wsection]
> extern const_debug unsigned int sysctl_sched_time_avg;
> ^
> ./include/linux/sched/sysctl.h:42:21: note: previous declaration is here
> extern unsigned int sysctl_sched_time_avg;
>
> The header only declares the variables when CONFIG_SCHED_DEBUG is defined,
> therefore it is not necessary to duplicate the definition of const_debug.
> Instead we can use the attribute __read_mostly, which is the expansion of
> const_debug when CONFIG_SCHED_DEBUG is set.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> ---
> Changes in v2:
> - removed pointless include of linux/static_key.h
> - added Reviewed-by tag
>
> include/linux/sched/sysctl.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/sched/sysctl.h b/include/linux/sched/sysctl.h
> index 0f5ecd4d298e..d34c823f3d36 100644
> --- a/include/linux/sched/sysctl.h
> +++ b/include/linux/sched/sysctl.h
> @@ -37,9 +37,9 @@ extern unsigned int sysctl_numa_balancing_scan_period_max;
> extern unsigned int sysctl_numa_balancing_scan_size;
>
> #ifdef CONFIG_SCHED_DEBUG
> -extern unsigned int sysctl_sched_migration_cost;
> -extern unsigned int sysctl_sched_nr_migrate;
> -extern unsigned int sysctl_sched_time_avg;
> +extern __read_mostly unsigned int sysctl_sched_migration_cost;
> +extern __read_mostly unsigned int sysctl_sched_nr_migrate;
> +extern __read_mostly unsigned int sysctl_sched_time_avg;
So I hate this change, because it pointlessly duplicates an attribute that should
only matter at the definition site. The Clang warning:
> kernel/sched/sched.h:1618:33: warning: section attribute is specified on
> redeclared variable [-Wsection]
suggests that the -Wsection warning can be turned off. The Clang build should
probably do that.
Thanks,
Ingo
next prev parent reply other threads:[~2017-10-31 10:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 18:08 [PATCH v2] sched/sysctl: Fix attributes of some extern declarations Matthias Kaehlcke
2017-10-31 9:57 ` Ingo Molnar [this message]
2017-10-31 22:31 ` Matthias Kaehlcke
2017-11-01 4:33 ` Nick Desaulniers
2017-11-01 8:34 ` Ingo Molnar
2017-11-01 8:45 ` [tip:sched/core] " tip-bot for Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031095758.wsgbrsdz7hzn5o2n@gmail.com \
--to=mingo@kernel.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=nick.desaulniers@gmail.com \
--cc=peterz@infradead.org \
--cc=shile.zhang@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).