From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932264AbdJaONp (ORCPT ); Tue, 31 Oct 2017 10:13:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:54502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752369AbdJaONo (ORCPT ); Tue, 31 Oct 2017 10:13:44 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4686C218D2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Tue, 31 Oct 2017 10:13:41 -0400 From: Steven Rostedt To: Arnd Bergmann Cc: Ingo Molnar , Joel Fernandes , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: always define trace_{irq,preempt}_{enable_disable} Message-ID: <20171031101341.4bc3c07b@gandalf.local.home> In-Reply-To: <20171019083230.2450779-1-arnd@arndb.de> References: <20171019083230.2450779-1-arnd@arndb.de> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Oct 2017 10:32:13 +0200 Arnd Bergmann wrote: > We get a build error in the irqsoff tracer in some configurations: > > kernel/trace/trace_irqsoff.c: In function 'trace_preempt_on': > kernel/trace/trace_irqsoff.c:855:2: error: implicit declaration of function 'trace_preempt_enable_rcuidle'; did you mean 'trace_irq_enable_rcuidle'? [-Werror=implicit-function-declaration] > trace_preempt_enable_rcuidle(a0, a1); > > The problem is that trace_preempt_enable_rcuidle() has different > definition based on multiple Kconfig symbols, but not all combinations > have a valid definition. > > This changes the conditions so that we always get exactly one > definition of each of the four tracing macros. I have not tried > to verify that these definitions are sensible, but now we > can build all randconfig combinations again. > > Fixes: d59158162e03 ("tracing: Add support for preempt and irq enable/disable events") > Signed-off-by: Arnd Bergmann Applied. Thanks Arnd. -- Steve