From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753516AbdJaPPF (ORCPT ); Tue, 31 Oct 2017 11:15:05 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48652 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753306AbdJaPPC (ORCPT ); Tue, 31 Oct 2017 11:15:02 -0400 Date: Tue, 31 Oct 2017 20:44:53 +0530 From: "Naveen N. Rao" To: sathnaga@linux.vnet.ibm.com Cc: acme@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, srikar@linux.vnet.ibm.com, bala24@linux.vnet.ibm.com Subject: Re: [PATCH v3 1/2] perf/bench/numa: Add functions to detect sparse numa nodes References: <855c8ed2d15135f2ac32105f60a745a4fd14036b.1503310062.git.sathnaga@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <855c8ed2d15135f2ac32105f60a745a4fd14036b.1503310062.git.sathnaga@linux.vnet.ibm.com> User-Agent: NeoMutt/20170912 (1.9.0) X-TM-AS-GCONF: 00 x-cbid: 17103115-0040-0000-0000-00000408E54B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17103115-0041-0000-0000-000020AB69FC Message-Id: <20171031151453.pe2ef33hyjl6bcxo@naverao1-tp.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-31_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=4 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710310192 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Satheesh, On 2017/08/21 10:15AM, sathnaga@linux.vnet.ibm.com wrote: > From: Satheesh Rajendran > > Added functions 1) to get a count of all nodes that are exposed to > userspace. These nodes could be memoryless cpu nodes or cpuless memory > nodes, 2) to check given node is present and 3) to check given > node has cpus > > This information can be used to handle sparse/discontiguous nodes. > > Cc: Arnaldo Carvalho de Melo > Reviewed-by: Srikar Dronamraju > Signed-off-by: Satheesh Rajendran > Signed-off-by: Balamuruhan S > --- > tools/perf/bench/numa.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c > index 469d65b..2483174 100644 > --- a/tools/perf/bench/numa.c > +++ b/tools/perf/bench/numa.c > @@ -215,6 +215,50 @@ static const char * const numa_usage[] = { > NULL > }; > > +/* > + * To get number of numa nodes present. > + */ > +static int nr_numa_nodes(void) > +{ > + int i, nr_nodes = 0; > + > + for (i = 0; i < g->p.nr_nodes; i++) { > + if (numa_bitmask_isbitset(numa_nodes_ptr, i)) > + nr_nodes++; > + } > + > + return nr_nodes; > +} > + > +/* Please run patches through scripts/checkpatch.pl. There is a trailing whitespace above... > + * To check if given numa node is present. > + */ > +static int is_node_present(int node) > +{ > + return numa_bitmask_isbitset(numa_nodes_ptr, node); > +} > + > +/* > + * To check given numa node has cpus. > + */ > +static bool node_has_cpus(int node) > +{ > + struct bitmask *cpu = numa_allocate_cpumask(); > + unsigned int i; > + > + if (cpu == NULL) > + return false; /* lets fall back to nocpus safely */ > + > + if (numa_node_to_cpus(node, cpu) == 0) { This can be simplified to: if (cpu && !numa_node_to_cpus(node, cpu)) { > + for (i = 0; i < cpu->size; i++) { > + if (numa_bitmask_isbitset(cpu, i)) > + return true; > + } > + } The indentation on those brackets look to be wrong. > + > + return false; > +} > + More importantly, you've introduced few functions in this patch, but none of those are being used. This is not a useful way to split your patches. In fact, this hurts bisect since trying to build perf with just this patch applied throws errors. You seem to be addressing a few different issues related to perf bench numa. You might want to split your patch based on the specific issue(s) each change fixes. - Naveen > static cpu_set_t bind_to_cpu(int target_cpu) > { > cpu_set_t orig_mask, mask; > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >