From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932698AbdJaTml (ORCPT <rfc822;w@1wt.eu>);
        Tue, 31 Oct 2017 15:42:41 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:56142 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932510AbdJaTmk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 31 Oct 2017 15:42:40 -0400
Date: Tue, 31 Oct 2017 20:42:52 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Long Li <longli@microsoft.com>
Cc: KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Paul Meyer <Paul.Meyer@microsoft.com>
Subject: Re: [PATCH] hv: kvp: Avoid reading past allocated blocks from KVP
 file
Message-ID: <20171031194252.GA21223@kroah.com>
References: <20171031000803.11571-1-longli@exchange.microsoft.com>
 <20171031084248.GA11479@kroah.com>
 <MWHPR21MB0190C9F2DCD0D34F2295D865CE5E0@MWHPR21MB0190.namprd21.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MWHPR21MB0190C9F2DCD0D34F2295D865CE5E0@MWHPR21MB0190.namprd21.prod.outlook.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 31, 2017 at 06:10:00PM +0000, Long Li wrote:
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Tuesday, October 31, 2017 1:43 AM
> > To: Long Li <longli@microsoft.com>
> > Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> > devel@linuxdriverproject.org; linux-kernel@vger.kernel.org; Paul Meyer
> > <Paul.Meyer@microsoft.com>
> > Subject: Re: [PATCH] hv: kvp: Avoid reading past allocated blocks from KVP file
> > 
> > On Mon, Oct 30, 2017 at 05:08:03PM -0700, Long Li wrote:
> > > From: Paul Meyer <Paul.Meyer@microsoft.com>
> > >
> > > While reading in more than one block (50) of KVP records, the
> > > allocation goes per block, but the reads used the total number of
> > > allocated records (without resetting the pointer/stream). This causes
> > > the records buffer to overrun when the refresh reads more than one
> > > block over the previous capacity (e.g. reading more than 100 KVP records
> > whereas the in-memory database was empty before).
> > 
> > Please wrap changelogs at 72 columns like your editor asked you to...
> 
> I will fix it.
> 
> > 
> > >
> > > Fix this by reading the correct number of KVP records from file each time.
> > >
> > > Signed-off-by: Paul Meyer <Paul.Meyer@microsoft.com>
> > > ---
> > 
> > Why is your name not also on the signed-off-by chain if you are forwarding on a
> > patch from someone else?
> > 
> > Is this patch also needed on stable kernels?
> 
> I'm sending on behalf of Paul Meyer. I will add a "Reviewed-by:" tag.

Sending on behalf means you should add your signed-off-by, as it is
going through you.

thanks,

greg k-h