From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752209AbdKAKKZ (ORCPT ); Wed, 1 Nov 2017 06:10:25 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:56350 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751943AbdKAKKW (ORCPT ); Wed, 1 Nov 2017 06:10:22 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Date: Wed, 1 Nov 2017 10:09:53 +0000 From: Charles Keepax To: Andrew Jeffery CC: , , , , , , , , , , , , Subject: Re: [PATCH v3 1/2] gpio: gpiolib: Generalise state persistence beyond sleep Message-ID: <20171101100953.ye5fp33vxuol5z5a@localhost.localdomain> References: <20171101040457.1200-1-andrew@aj.id.au> <20171101040457.1200-2-andrew@aj.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171101040457.1200-2-andrew@aj.id.au> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1711010144 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 01, 2017 at 03:04:56PM +1100, Andrew Jeffery wrote: > General support for state persistence is added to gpiolib with the > introduction of a new pinconf parameter to propagate the request to > hardware. The existing persistence support for sleep is adapted to > include hardware support if the GPIO driver provides it. Persistence > continues to be enabled by default; in-kernel consumers can opt out, but > userspace (currently) does not have a choice. > > The *_SLEEP_MAY_LOSE_VALUE and *_SLEEP_MAINTAIN_VALUE symbols are > renamed, dropping the SLEEP prefix to reflect that the concept is no > longer sleep-specific. I feel that renaming to just *_MAY_LOSE_VALUE > could initially be misinterpreted, so I've further changed the symbols > to *_TRANSITORY and *_PERSISTENT to address this. > > The sysfs interface is modified only to keep consistency with the > chardev interface in enforcing persistence for userspace exports. > > Signed-off-by: Andrew Jeffery > --- Reviewed-by: Charles Keepax Thanks, Charles