From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754453AbdKAK6t (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Nov 2017 06:58:49 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:19039 "EHLO
        aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752058AbdKAK6r (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Nov 2017 06:58:47 -0400
Date: Wed, 1 Nov 2017 13:58:30 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        driverdev-devel@linuxdriverproject.org, linux-crypto@vger.kernel.org,
        Ofir Drang <ofir.drang@arm.com>
Subject: Re: [PATCH 1/3] staging: ccree: copy IV to DMAable memory
Message-ID: <20171101105830.skfd4pcnibpnmkxr@mwanda>
References: <1509450978-17784-1-git-send-email-gilad@benyossef.com>
 <1509450978-17784-2-git-send-email-gilad@benyossef.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1509450978-17784-2-git-send-email-gilad@benyossef.com>
User-Agent: NeoMutt/20170609 (1.8.3)
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 31, 2017 at 11:56:15AM +0000, Gilad Ben-Yossef wrote:
> +
> +	/* The IV we are handed may be allocted from the stack so
> +	 * we must copy it to a DMAable buffer before use.
> +	 */
> +	req_ctx->iv = kmalloc(ivsize, GFP_KERNEL);
> +	memcpy(req_ctx->iv, info, ivsize);

We need to check if kmalloc() fails.

regards,
dan carpenter