From: Gustavo Padovan <gustavo@padovan.org>
To: Philippe Cornu <philippe.cornu@st.com>
Cc: Yannick Fertre <yannick.fertre@st.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Vincent Abriou <vincent.abriou@st.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@st.com>,
Fabien Dessenne <fabien.dessenne@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Mickael Reulier <mickael.reulier@st.com>,
Gabriel Fernandez <gabriel.fernandez@st.com>,
Ludovic Barre <ludovic.barre@st.com>
Subject: Re: [PATCH] drm/stm: checkpatch strict minor updates
Date: Wed, 1 Nov 2017 09:33:01 -0200 [thread overview]
Message-ID: <20171101113301.GD4111@jade> (raw)
In-Reply-To: <1509013473-18365-1-git-send-email-philippe.cornu@st.com>
2017-10-26 Philippe Cornu <philippe.cornu@st.com>:
> Minor fixes detected with "scripts/checkpatch.pl --strict"
>
> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
> ---
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 ++--
> drivers/gpu/drm/stm/ltdc.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 10b2b77..3e8b9ed 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -129,7 +129,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz,
> int fvco_min, fvco_max, delta, best_delta; /* all in khz */
>
> /* Early checks preventing division by 0 & odd results */
> - if ((clkin_khz <= 0) || (clkout_khz <= 0))
> + if (clkin_khz <= 0 || clkout_khz <= 0)
> return -EINVAL;
>
> fvco_min = LANE_MIN_KBPS * 2 * ODF_MAX;
> @@ -155,7 +155,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz,
> for (o = ODF_MIN; o <= ODF_MAX; o *= 2) {
> n = DIV_ROUND_CLOSEST(i * o * clkout_khz, clkin_khz);
> /* Check ndiv according to vco range */
> - if ((n < n_min) || (n > n_max))
> + if (n < n_min || n > n_max)
> continue;
> /* Check if new delta is better & saves parameters */
> delta = dsi_pll_get_clkout_khz(clkin_khz, i, n, o) -
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 735c908..7be6710 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -556,7 +556,7 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,
> src_h = state->src_h >> 16;
>
> /* Reject scaling */
> - if ((src_w != state->crtc_w) || (src_h != state->crtc_h)) {
> + if (src_w != state->crtc_w || src_h != state->crtc_h) {
> DRM_ERROR("Scaling is not supported");
> return -EINVAL;
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
next prev parent reply other threads:[~2017-11-01 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 10:24 [PATCH] drm/stm: checkpatch strict minor updates Philippe Cornu
2017-11-01 11:33 ` Gustavo Padovan [this message]
2017-11-07 13:57 ` Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101113301.GD4111@jade \
--to=gustavo@padovan.org \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabien.dessenne@st.com \
--cc=gabriel.fernandez@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.barre@st.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mickael.reulier@st.com \
--cc=philippe.cornu@st.com \
--cc=vincent.abriou@st.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).