From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754547AbdKAMED (ORCPT ); Wed, 1 Nov 2017 08:04:03 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:36378 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbdKAMEC (ORCPT ); Wed, 1 Nov 2017 08:04:02 -0400 Date: Wed, 1 Nov 2017 13:03:54 +0100 From: Andrew Lunn To: Egil Hjelmeland Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 3/3] net: dsa: lan9303: lan9303_rcv set skb->offload_fwd_mark Message-ID: <20171101120354.GA12680@lunn.ch> References: <20171031144802.12686-1-privat@egil-hjelmeland.no> <20171031144802.12686-4-privat@egil-hjelmeland.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171031144802.12686-4-privat@egil-hjelmeland.no> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > One exception: Because the ALR is set up to forward STP BPDUs only to CPU, > the SW bridge should flood STP BPDUs if local STP is not enabled. > This is archived by not setting skb->offload_fwd_mark on STP BPDUs. Hi Egil This bit is interesting. I had not thought about that. I think we need a few more drivers to set offload_fwd_mark, and then maybe try to consolidate it into the core. But it is too early now. Reviewed-by: Andrew Lunn Andrew