From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754535AbdKAMI3 (ORCPT ); Wed, 1 Nov 2017 08:08:29 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:51177 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbdKAMI1 (ORCPT ); Wed, 1 Nov 2017 08:08:27 -0400 X-Google-Smtp-Source: ABhQp+R07FpnSFQvDsIkHksBQXccQyjWg4q+wblxv9QCWcedsJp3DFM40yR3JGkhJ+GHBsNTuvLHXA== Date: Wed, 1 Nov 2017 21:05:59 +0900 From: Namhyung Kim To: Milian Wolff Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , kernel-team@lge.com, Jin Yao Subject: Re: [PATCH 2/2] perf tools: Show correct function name for srcline of callchains Message-ID: <20171101120559.GC26623@danjae.aot.lge.com> References: <20171031020654.31163-1-namhyung@kernel.org> <20171031020654.31163-2-namhyung@kernel.org> <2208660.mvSdWdKhUF@milian-kdab2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2208660.mvSdWdKhUF@milian-kdab2> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Milian, On Wed, Nov 01, 2017 at 10:57:12AM +0100, Milian Wolff wrote: > On Tuesday, October 31, 2017 3:06:54 AM CET Namhyung Kim wrote: > > When libbfd is not used, it doesn't show proper function name and reuse > > the original symbol of the sample. That's because it passes the > > original sym to inline_list__append(). As `addr2line -f` returns > > function names as well, use that to create ad inline_sym and pass it to > > inline_list__append(). > > Typo above: "ad" -> "and" I think it's "an" instead of "and". :) > > Otherwise these patches look fine to me > > Reviewed-by: Milian Wolff Thanks, Namhyung