From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754589AbdKAMfJ (ORCPT ); Wed, 1 Nov 2017 08:35:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:50276 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754336AbdKAMfI (ORCPT ); Wed, 1 Nov 2017 08:35:08 -0400 Date: Wed, 1 Nov 2017 13:35:02 +0100 From: Borislav Petkov To: Andy Lutomirski Cc: X86 ML , "linux-kernel@vger.kernel.org" , Brian Gerst , Dave Hansen , Linus Torvalds Subject: Re: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths Message-ID: <20171101123502.b7enfbablicdfujj@pd.tnic> References: <998a8c2c39546115f93e4c6e2ad7f918626f6145.1509006199.git.luto@kernel.org> <20171027201125.GD12039@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 01, 2017 at 04:29:21AM -0700, Andy Lutomirski wrote: > I'm inclined to leave it. I first wrote it without the long name and > then I had to re-read the code to make sure I got the register state > right. The long name serves as documentation that we need rcx and r11 > to have special contents. There's only one place that jumps there and > it's in the same function. Frankly, I'd prefer a sane label name and a good comment over it instead of insanely long label name which is not as explanatory as a normal english sentence or two. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --