From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754727AbdKAPRv (ORCPT ); Wed, 1 Nov 2017 11:17:51 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33492 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587AbdKAPRu (ORCPT ); Wed, 1 Nov 2017 11:17:50 -0400 Date: Wed, 1 Nov 2017 16:18:03 +0100 From: Greg Kroah-Hartman To: Thomas Backlund Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Steve French Subject: Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed Message-ID: <20171101151803.GB31285@kroah.com> References: <20171031095530.520746935@linuxfoundation.org> <20171031095531.633196173@linuxfoundation.org> <97340c9a-0ea2-0d3d-cf26-58c799d76cae@mageia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <97340c9a-0ea2-0d3d-cf26-58c799d76cae@mageia.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: > Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: > > 4.13-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Steve French > > > > commit 4587eee04e2ac7ac3ac9fa2bc164fb6e548f99cd upstream. > > > > According to MS-SMB2 3.2.55 validate_negotiate request must > > always be signed. Some Windows can fail the request if you send it unsigned > > > > See kernel bugzilla bug 197311 > > > > Acked-by: Ronnie Sahlberg > > Signed-off-by: Steve French > > Signed-off-by: Greg Kroah-Hartman > > > > --- > > fs/cifs/smb2pdu.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > --- a/fs/cifs/smb2pdu.c > > +++ b/fs/cifs/smb2pdu.c > > @@ -1963,6 +1963,9 @@ SMB2_ioctl(const unsigned int xid, struc > > } else > > iov[0].iov_len = get_rfc1002_length(req) + 4; > > + /* validate negotiate request must be signed - see MS-SMB2 3.2.5.5 */ > > + if (opcode == FSCTL_VALIDATE_NEGOTIATE_INFO) > > + req->hdr.sync_hdr.Flags |= SMB2_FLAGS_SIGNED; > > rc = SendReceive2(xid, ses, iov, n_iov, &resp_buftype, flags, &rsp_iov); > > cifs_small_buf_release(req); > > > > > > > > This one needs to be backported to all stable kernels as the commit that > introduced the regression: > ' > 0603c96f3af50e2f9299fa410c224ab1d465e0f9 > SMB: Validate negotiate (to protect against downgrade) even if signing off > > is backported in stable trees as of: 4.9.53, 4.4.90, 3.18.73 Oh wait, it breaks the builds on older kernels, that's why I didn't apply it :) Can you provide me with a working backport? thanks, greg k-h