From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932481AbdKARMf (ORCPT ); Wed, 1 Nov 2017 13:12:35 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:26114 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbdKARMc (ORCPT ); Wed, 1 Nov 2017 13:12:32 -0400 Date: Wed, 1 Nov 2017 12:11:24 -0500 From: Tom Saeger To: Joe Perches Cc: Tom Saeger , linux-kernel@vger.kernel.org, xen-devel , mercurial-devel@mercurial-scm.org Subject: Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns Message-ID: <20171101171124.7eqbght7nw6vj2oy@revenge.us.oracle.com> References: <20171031213740.25510-1-tom.saeger@oracle.com> <1509555005.31043.43.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509555005.31043.43.camel@perches.com> User-Agent: NeoMutt/20171027 X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 01, 2017 at 09:50:05AM -0700, Joe Perches wrote: > (add mercurial-devel and xen-devel to cc's) > > On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote: > > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid > > "F" and "X" patterns found in MAINTAINERS file(s). > > Hey again Tom. > > About mercurial/hg. > > While as far as I know there hasn't been a mercurial tree > for the linux kernel sources in many years, I believe the > mercurial command to list files should be different. > > > my %VCS_cmds_hg = ( > > @@ -167,6 +169,7 @@ my %VCS_cmds_hg = ( > > "subject_pattern" => "^HgSubject: (.*)", > > "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$", > > "file_exists_cmd" => "hg files \$file", > > + "list_files_cmd" => "hg files \$file", > > I think this should be > > "list_files_cmd" => "hg manifest -R \$file", Ok - I'll add to v2.