From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933446AbdKAVNC (ORCPT ); Wed, 1 Nov 2017 17:13:02 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:53824 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933262AbdKAVNA (ORCPT ); Wed, 1 Nov 2017 17:13:00 -0400 X-Google-Smtp-Source: ABhQp+QAxFGNM/6UxxrGCmSldX4I0ydcTcY2ng8kkcfx3iYv/3G8UprHvSF7cO0/Izq7kz4mqwN7Sw== Date: Wed, 1 Nov 2017 16:12:58 -0500 From: Rob Herring To: Icenowy Zheng Cc: Maxime Ripard , Chen-Yu Tsai , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 01/10] dt-bindings: fix the binding of Allwinner DE2 CCU of A83T and H3 Message-ID: <20171101211258.m7lk4s2glhxhs7el@rob-hp-laptop> References: <20171027150658.18509-1-icenowy@aosc.io> <20171027150658.18509-2-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171027150658.18509-2-icenowy@aosc.io> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 27, 2017 at 11:06:49PM +0800, Icenowy Zheng wrote: > The DE2 CCU is different on A83T and H3 -- the parent of the clocks on > A83T is PLL_DE but on H3 it's the DE module clock. This is not noticed > when I develop the DE2 CCU driver. > > Fix the binding by using different compatibles for A83T and H3, adding > notes for the PLL_DE usage on A83T, and change the binding example's > compatible from A83T to H3 (as it specifies the DE module clock). > > Fixes: ed74f8a8a679 ("dt-bindings: add binding for the Allwinner DE2 CCU") > Signed-off-by: Icenowy Zheng > --- > Documentation/devicetree/bindings/clock/sun8i-de2.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Acked-by: Rob Herring