From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755032AbdKBGyB (ORCPT ); Thu, 2 Nov 2017 02:54:01 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:43798 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbdKBGyA (ORCPT ); Thu, 2 Nov 2017 02:54:00 -0400 Date: Thu, 02 Nov 2017 15:53:55 +0900 (KST) Message-Id: <20171102.155355.680097222661424519.davem@davemloft.net> To: colin.king@canonical.com Cc: tklauser@distanz.ch, tremyfr@gmail.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dl2k: remove redundant re-assignment to np From: David Miller In-Reply-To: <20171101085737.14967-1-colin.king@canonical.com> References: <20171101085737.14967-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 01 Nov 2017 23:53:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Wed, 1 Nov 2017 08:57:37 +0000 > From: Colin Ian King > > The pointer np is initialized and then re-assigned the same value > a few lines later. Remove the redundant duplicated assignment. Cleans > up clang warning: > > drivers/net/ethernet/dlink/dl2k.c:314:25: warning: Value stored to > 'np' during its initialization is never read > > Signed-off-by: Colin Ian King Applied.