From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755238AbdKBGyR (ORCPT ); Thu, 2 Nov 2017 02:54:17 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:43814 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755097AbdKBGyP (ORCPT ); Thu, 2 Nov 2017 02:54:15 -0400 Date: Thu, 02 Nov 2017 15:54:11 +0900 (KST) Message-Id: <20171102.155411.1611979100337438252.davem@davemloft.net> To: colin.king@canonical.com Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, linyunsheng@huawei.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: hns3: remove a couple of redundant assignments From: David Miller In-Reply-To: <20171101101715.17617-1-colin.king@canonical.com> References: <20171101101715.17617-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 01 Nov 2017 23:54:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Wed, 1 Nov 2017 10:17:15 +0000 > From: Colin Ian King > > The assignment to kinfo is redundant as this is a duplicate of > the initialiation of kinfo a few lines earlier, so it can be > removed. The assignment to v_tc_info is never read, so this > variable is redundant and can be removed completely. Cleans > up two clang warnings: > > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c:433:34: > warning: Value stored to 'kinfo' during its initialization is never read > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c:775:3: > warning: Value stored to 'v_tc_info' is never read > > Signed-off-by: Colin Ian King Applied.