From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932660AbdKBMnv (ORCPT ); Thu, 2 Nov 2017 08:43:51 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38932 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752139AbdKBMnr (ORCPT ); Thu, 2 Nov 2017 08:43:47 -0400 Date: Thu, 2 Nov 2017 13:43:39 +0100 From: Andrew Lunn To: David Daney Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, James Hogan , netdev@vger.kernel.org, "David S. Miller" , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, "Steven J. Hill" , devicetree@vger.kernel.org, Carlos Munoz Subject: Re: [PATCH 6/7] netdev: octeon-ethernet: Add Cavium Octeon III support. Message-ID: <20171102124339.GF4772@lunn.ch> References: <20171102003606.19913-1-david.daney@cavium.com> <20171102003606.19913-7-david.daney@cavium.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171102003606.19913-7-david.daney@cavium.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static int bgx_probe(struct platform_device *pdev) > +{ > + struct mac_platform_data platform_data; > + const __be32 *reg; > + u32 port; > + u64 addr; > + struct device_node *child; > + struct platform_device *new_dev; > + struct platform_device *pki_dev; > + int numa_node, interface; > + int i; > + int r = 0; > + char id[64]; > + u64 data; > + > + reg = of_get_property(pdev->dev.of_node, "reg", NULL); > + addr = of_translate_address(pdev->dev.of_node, reg); > + interface = (addr >> 24) & 0xf; > + numa_node = (addr >> 36) & 0x7; > + > + /* Assign 8 CAM entries per LMAC */ > + for (i = 0; i < 32; i++) { > + data = i >> 3; > + oct_csr_write(data, BGX_CMR_RX_ADRX_CAM(numa_node, interface, i)); > + } > + > + for_each_available_child_of_node(pdev->dev.of_node, child) { > + snprintf(id, sizeof(id), "%llx.%u.ethernet-mac", > + (unsigned long long)addr, port); > + new_dev = of_platform_device_create(child, id, &pdev->dev); > + if (!new_dev) { > + dev_err(&pdev->dev, "Error creating %s\n", id); > + continue; > + } > + platform_data.mac_type = BGX_MAC; > + platform_data.numa_node = numa_node; > + platform_data.interface = interface; > + platform_data.port = port; > + if (is_xcv) > + platform_data.src_type = XCV; > + else > + platform_data.src_type = QLM; > + > + /* Add device to the list of created devices so we can remove it > + * on exit. > + */ > + pdev_item = kmalloc(sizeof(*pdev_item), GFP_KERNEL); > + pdev_item->pdev = new_dev; > + mutex_lock(&pdev_list_lock); > + list_add(&pdev_item->list, &pdev_list); > + mutex_unlock(&pdev_list_lock); > + > + i = atomic_inc_return(&pki_id); > + pki_dev = platform_device_register_data(&new_dev->dev, > + is_mix ? "octeon_mgmt" : "ethernet-mac-pki", > + i, &platform_data, sizeof(platform_data)); > + dev_info(&pdev->dev, "Created %s %u: %p\n", > + is_mix ? "MIX" : "PKI", pki_dev->id, pki_dev); Is there any change of these ethernet ports being used to connect to an Ethernet switch. We have had issues in the past with these sort of platform devices combined with DSA. Andrew