* [PATCH] platform/x86: intel_telemetry: add back linux/io.h inclusion
@ 2017-11-02 16:49 Arnd Bergmann
2017-11-03 1:01 ` Darren Hart
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-11-02 16:49 UTC (permalink / raw)
To: Souvik Kumar Chakravarty, Darren Hart, Andy Shevchenko
Cc: Arnd Bergmann, Rajneesh Bhardwaj, Shanth Murthy,
platform-driver-x86, linux-kernel
This one wasn't redundant after all, as shown by this randconfig
build error:
drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telem_evtlog_read':
drivers/platform/x86/intel_telemetry_pltdrv.c:900:20: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]
We should generally include exactly the set of headers that declare
the interfaces we use, so this adds back the missing include to
get it to compile again.
Fixes: a5e50220edbd ("platform/x86: intel_telemetry: cleanup redundant headers")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/platform/x86/intel_telemetry_pltdrv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
index 678abf2e9e92..45f790a22ca2 100644
--- a/drivers/platform/x86/intel_telemetry_pltdrv.c
+++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
@@ -16,6 +16,7 @@
* It used the PUNIT and PMC IPC interfaces for configuring the counters.
* The accumulated results are fetched from SRAM.
*/
+#include <linux/io.h>
#include <linux/module.h>
#include <linux/platform_device.h>
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: intel_telemetry: add back linux/io.h inclusion
2017-11-02 16:49 [PATCH] platform/x86: intel_telemetry: add back linux/io.h inclusion Arnd Bergmann
@ 2017-11-03 1:01 ` Darren Hart
0 siblings, 0 replies; 2+ messages in thread
From: Darren Hart @ 2017-11-03 1:01 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Souvik Kumar Chakravarty, Andy Shevchenko, Rajneesh Bhardwaj,
Shanth Murthy, platform-driver-x86, linux-kernel
On Thu, Nov 02, 2017 at 05:49:27PM +0100, Arnd Bergmann wrote:
> This one wasn't redundant after all, as shown by this randconfig
> build error:
>
> drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telem_evtlog_read':
> drivers/platform/x86/intel_telemetry_pltdrv.c:900:20: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]
>
> We should generally include exactly the set of headers that declare
> the interfaces we use, so this adds back the missing include to
> get it to compile again.
Thanks Arnd, Andy already caught this and has it queued.
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-03 1:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 16:49 [PATCH] platform/x86: intel_telemetry: add back linux/io.h inclusion Arnd Bergmann
2017-11-03 1:01 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).