From: Eduardo Valentin <eduval@amazon.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Eduardo Valentin <eduval@amazon.com>, <rkrcmar@redhat.com>,
Matt Wilson <msw@amazon.com>, Jonathan Corbet <corbet@lwn.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<x86@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
Waiman Long <longman@redhat.com>, <kvm@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Jan H . Schoenherr" <jschoenh@amazon.de>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [PATCHv2 1/1] locking/qspinlock/x86: Avoid test-and-set when PV_DEDICATED is set
Date: Thu, 2 Nov 2017 11:08:54 -0700 [thread overview]
Message-ID: <20171102180854.GA27676@u40b0340c692b58f6553c.ant.amazon.com> (raw)
In-Reply-To: <6bd9aee8-1d9e-d088-d13d-653c0628b394@redhat.com>
On Thu, Nov 02, 2017 at 06:56:46PM +0100, Paolo Bonzini wrote:
> On 02/11/2017 18:45, Eduardo Valentin wrote:
> > Currently, the existing qspinlock implementation will fallback to
> > test-and-set if the hypervisor has not set the PV_UNHALT flag.
> >
> > This patch gives the opportunity to guest kernels to select
> > between test-and-set and the regular queueu fair lock implementation
> > based on the PV_DEDICATED KVM feature flag. When the PV_DEDICATED
> > flag is not set, the code will still fall back to test-and-set,
> > but when the PV_DEDICATED flag is set, the code will use
> > the regular queue spinlock implementation.
>
> Have you seen Waiman's series that lets you specify this on the guest
> command line instead? Would this be acceptable for your use case?
>
No, can you please share a link to it? is it already merged to tip/master?
> (In other words, is there a difference for you between making the host
> vs. guest administrator toggle the feature? "@amazon.com" means you are
> the host admin, how would you use it?)
>
The way I think of this is this is a flag set by host side so the guest adapts accordingly.
If the admin in guest side wants to ignore what the host is flagging, that is a different story.
> Thanks,
>
> Paolo
>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: "Radim Krčmář" <rkrcmar@redhat.com>
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: x86@kernel.org
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Waiman Long <longman@redhat.com>
> > Cc: kvm@vger.kernel.org
> > Cc: linux-doc@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Cc: Jan H. Schoenherr <jschoenh@amazon.de>
> > Cc: Anthony Liguori <aliguori@amazon.com>
> > Suggested-by: Matt Wilson <msw@amazon.com>
> > Signed-off-by: Eduardo Valentin <eduval@amazon.com>
> > ---
> > V2:
> > - rebase on top of tip/master
> >
> > Documentation/virtual/kvm/cpuid.txt | 6 ++++++
> > arch/x86/include/asm/qspinlock.h | 4 ++++
> > arch/x86/include/uapi/asm/kvm_para.h | 1 +
> > 3 files changed, 11 insertions(+)
> >
> > diff --git a/Documentation/virtual/kvm/cpuid.txt b/Documentation/virtual/kvm/cpuid.txt
> > index 3c65feb..117066a 100644
> > --- a/Documentation/virtual/kvm/cpuid.txt
> > +++ b/Documentation/virtual/kvm/cpuid.txt
> > @@ -54,6 +54,12 @@ KVM_FEATURE_PV_UNHALT || 7 || guest checks this feature bit
> > || || before enabling paravirtualized
> > || || spinlock support.
> > ------------------------------------------------------------------------------
> > +KVM_FEATURE_PV_DEDICATED || 8 || guest checks this feature bit
> > + || || to determine if they run on
> > + || || dedicated vCPUs, allowing opti-
> > + || || mizations such as usage of
> > + || || qspinlocks.
> > +------------------------------------------------------------------------------
> > KVM_FEATURE_CLOCKSOURCE_STABLE_BIT || 24 || host will warn if no guest-side
> > || || per-cpu warps are expected in
> > || || kvmclock.
> > diff --git a/arch/x86/include/asm/qspinlock.h b/arch/x86/include/asm/qspinlock.h
> > index 308dfd0..3751898 100644
> > --- a/arch/x86/include/asm/qspinlock.h
> > +++ b/arch/x86/include/asm/qspinlock.h
> > @@ -2,6 +2,8 @@
> > #define _ASM_X86_QSPINLOCK_H
> >
> > #include <linux/jump_label.h>
> > +#include <linux/kvm_para.h>
> > +
> > #include <asm/cpufeature.h>
> > #include <asm-generic/qspinlock_types.h>
> > #include <asm/paravirt.h>
> > @@ -57,6 +59,8 @@ static inline bool virt_spin_lock(struct qspinlock *lock)
> > if (!static_branch_likely(&virt_spin_lock_key))
> > return false;
> >
> > + if (kvm_para_has_feature(KVM_FEATURE_PV_DEDICATED))
> > + return false;
> > /*
> > * On hypervisors without PARAVIRT_SPINLOCKS support we fall
> > * back to a Test-and-Set spinlock, because fair locks have
> > diff --git a/arch/x86/include/uapi/asm/kvm_para.h b/arch/x86/include/uapi/asm/kvm_para.h
> > index a965e5b0..d151300 100644
> > --- a/arch/x86/include/uapi/asm/kvm_para.h
> > +++ b/arch/x86/include/uapi/asm/kvm_para.h
> > @@ -24,6 +24,7 @@
> > #define KVM_FEATURE_STEAL_TIME 5
> > #define KVM_FEATURE_PV_EOI 6
> > #define KVM_FEATURE_PV_UNHALT 7
> > +#define KVM_FEATURE_PV_DEDICATED 8
> >
> > /* The last 8 bits are used to indicate how to interpret the flags field
> > * in pvclock structure. If no bits are set, all flags are ignored.
> >
>
>
--
All the best,
Eduardo Valentin
next prev parent reply other threads:[~2017-11-02 18:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 17:45 [PATCHv2 1/1] locking/qspinlock/x86: Avoid test-and-set when PV_DEDICATED is set Eduardo Valentin
2017-11-02 17:56 ` Paolo Bonzini
2017-11-02 18:08 ` Eduardo Valentin [this message]
2017-11-02 18:12 ` Waiman Long
2017-11-02 18:27 ` Eduardo Valentin
2017-11-02 18:24 ` Paolo Bonzini
2017-11-02 18:43 ` Eduardo Valentin
2017-11-03 10:09 ` Paolo Bonzini
2017-11-03 16:40 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102180854.GA27676@u40b0340c692b58f6553c.ant.amazon.com \
--to=eduval@amazon.com \
--cc=aliguori@amazon.com \
--cc=corbet@lwn.net \
--cc=hpa@zytor.com \
--cc=jschoenh@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=msw@amazon.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).