From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964852AbdKBUGs (ORCPT ); Thu, 2 Nov 2017 16:06:48 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:53860 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932497AbdKBUGq (ORCPT ); Thu, 2 Nov 2017 16:06:46 -0400 Date: Thu, 2 Nov 2017 16:06:20 -0400 From: Roman Gushchin To: Joe Perches CC: , Tejun Heo , Alexei Starovoitov , Daniel Borkmann , , , "David S . Miller" Subject: Re: [PATCH v3 net-next 1/5] device_cgroup: add DEVCG_ prefix to ACC_* and DEV_* constants Message-ID: <20171102200616.GA631@castle.DHCP.thefacebook.com> References: <20171102171530.7627-1-guro@fb.com> <20171102171530.7627-2-guro@fb.com> <1509645252.31043.91.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1509645252.31043.91.camel@perches.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [2620:10d:c091:200::3dc0] X-ClientProxiedBy: BN6PR06CA0026.namprd06.prod.outlook.com (2603:10b6:405:3a::15) To BL2PR15MB1076.namprd15.prod.outlook.com (2603:10b6:201:17::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 36aa2299-1ce2-44c0-0e72-08d5222d31b7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:BL2PR15MB1076; X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1076;3:bPB/fWhWsWdktP0Q0zLmycIi7ib/vGMQaLSJTzMKPaVdeB08d+6aUthWD74HO8tnsiRQrM1pnxY+ohAQ89RR3lni/P3ETYtMndCa6dSTVE/16Tusy4am4NLCfZiYLONvRO/k82bl9klN/de7kxFxhGRXRyUncfPtuKmduN4xs++wz1K/6dj9HttpRTYwf8o/mmCNh9fk8MUgH7mXcy64MB2ql7Ql2GjV3kFlEgV0FzrxL5qtZQHGEDdJ/wekYWzx;25:KR9Em4HOEC6tN/B2JCMaS4/OoBZpFFjwgf15h1Tj6t7sg2c49cJTSzQKjMabVKdLhG1bKZSsHWVOnOdtbdmCsxcWCRmuwX3Z7S4ZphFZVwLkCkdvr9/Z4gxJemdXgKrfKCcNVqKd74Cj+FKxYiQuaLHRId964QjYC0ShmvAWsMHXscliKCIYP/AuBKwoQ4WSeh+95n0VeWOHa4wEbKrNvmPhvP4JHeSMIIGq6+Tqw1S45waAzB8fB/agyQ6dlhtjn3cgD40c7jhsycnzs9lUf+MkMokPE+YT91vM9bIUyO0ctll+ruznF/LkHhDzkrpdrldPWTC+0Zh3ntXTE4f8EA==;31:v2ywJxYEJZAnub7FaXLxUBK6HzQdZ3jiQqVS/RXZuN/x3EEpuo9di0S0LlV0hkDE303/lz6I7xDUB8dD5jlwxaJXIAOxqF581g/sKQzz1V7mPRT6cPzH1zC02b26b6Shwy+QqIoqYwvFo+ebPZ2QMEWAsqR8d1nt782e4Rvxbgj8SQBWAMOAOa0RTVJLSLZZFZkSSSwKGhVNgKYOTmHJwSkUOgnM8SLPPzcr4JapOFs= X-MS-TrafficTypeDiagnostic: BL2PR15MB1076: X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1076;20:S0FZJBu/xScJDBdExx9q+NoeVdjusEj8ItA6sH+/IKJAVyn8ZwIeuDaE5i8UbTr6WXpC2fwcdVDLXOakcga9u9TFdK0bH+hWgz5ps1ZPBHlC+o+Kbc80zYLvokOKyfXoe3Gi18RpGnLE5bMf6oOjuXbq76PgyWzh9Rb6eVF7oKJgQ/rNTMyG+6aLOj5JisELgITdyIeSdhI2f0OtJoXzqTZZbkT1JhjfNIgNWH640VmMV6w5JtXm2puyCw+vWpAU+hQo4DiEQRIid8waGUwj89CkDa9zQZkMFicDd7JYqmiBfwmEnM7aou+DdToaZmDoSkNg11iwxF5iUpLajSglepr+BnteQREjzuHJ66iYjsqCqqx5RpdVDAg+GSu5j7DPXspWHKRvr/IpQFkPSfgfFxHmGChFZL/G32pXqZXkx1GdjsCPIGmuqjnLkqCIuerHihL15Va8y2lvX6o1c4rnmswgfVJDpz7dh/9+EvzZTq++MoeJNTOLMwbPRId2RZmD;4:NJcVuomAzhrcoLLRJpuf/jeaVGIrRKyKYpAnUT7Xi2ERekdsnqTOxKOcinCp64G5QjDyVxrY7/CZqESFSnjHEqzqFWF/hG/R8hkaGzdU6ogtGT2B80yKERRAeFFXR6QrYa7ZIZAIrRkYGOOB1cZ3qRW1PGG44zPhG6ndpK2NqgVquV1WvMRkN075HwqjrbfWeUiekp6xvUwVfXgf7edRkw//61+perG0vPYPCeq6LKXKSPAz4bk9e0312Lr6YQXt8qmZmGG6AWHMx+31Z4LtLJDJnbmIA1Yi+HdL7+OtlUmhUOLBpipzvANxBTrKoYz/ X-Exchange-Antispam-Report-Test: UriScan:(192374486261705); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(11241501159)(6040450)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(3231020)(93006095)(93001095)(10201501046)(6041248)(20161123564025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BL2PR15MB1076;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BL2PR15MB1076; X-Forefront-PRVS: 047999FF16 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(189002)(24454002)(377424004)(199003)(478600001)(33656002)(16586007)(58126008)(97736004)(105586002)(106356001)(50986999)(54356999)(101416001)(76176999)(2906002)(316002)(54906003)(47776003)(81166006)(81156014)(8936002)(8676002)(68736007)(6506006)(4326008)(189998001)(23726003)(53936002)(6116002)(9686003)(305945005)(7736002)(50466002)(83506002)(6916009)(86362001)(25786009)(55016002)(229853002)(6246003)(2950100002)(1076002)(5660300001)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR15MB1076;H:castle.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR15MB1076;23:x6lu0p41e+wqTGhxzESOQUiSg5xlsn7SvI46FgqjD?= =?us-ascii?Q?47ItKVQHStlkQG544FYvxkAseHCVRabFqqnwaoAjeuIHI+IaP79AxJ8GwGLB?= =?us-ascii?Q?+mhMbmFqI/7MJYXDd5vXRb5qhOxcxLlefriXDTSRRAc+qM7Jz+ijeYRWDNQ3?= =?us-ascii?Q?g4/BYR7RhAELL3fJjUfN06MsQPYzznzSdhDCb8pUjQmWxmIh/8t7w3qCaQMP?= =?us-ascii?Q?3PrUQ02MYx7AvY84sGLy4ZlwqIXSZNpya8DxIet/Wwx5QuyuVlfJdE580KiT?= =?us-ascii?Q?k0l8l9Tymj21Xhxg7DVfPlvI53NnfGx+WdODbcMf1UsHjjalwtAoj6lp3PtM?= =?us-ascii?Q?xrjU30wQGjLIPEOXij2FO3eh0A3rpbxv5OrJ+cNwoiP2bUizVcCrIbra5Svf?= =?us-ascii?Q?jxivIO/l6r25oAbF3boqyFKnOR9Gw9C//yqg3F00gOKaVHZ2qXmEbdmnMR/m?= =?us-ascii?Q?KyDae2ypbfeTAitPtBosM9mkp5x3bTNFx0fJ8m2W8jY/RK3ECDUxbomKnTbr?= =?us-ascii?Q?ReDLzU2eq5R4zm9/LmLXlbAzSSq9yof4BOFycUigpM2eLb93kbDedYWoapCw?= =?us-ascii?Q?npelEm4z1ktL7BtWTPRZNSmcg9pIvOUcSAcL5nT6D7FTTFBhWgiyTuD/yK92?= =?us-ascii?Q?tJ5H2tlLtToXIiu+oRSlT9jb2scynD5TqwVBYsWEOZ+qiG/WGW6reHmk+JVY?= =?us-ascii?Q?XIyWv3DFtJy2OmWTQ9a6UJ/3g/3IEGMUdSoeLH3kQBK7K63iIBhD//erXy/y?= =?us-ascii?Q?GnHvqonHy0zs1i7OMwjQIbgQM+4FLqEqJFEJUVVHjyNHZBbO1ItPIX1Cv/R2?= =?us-ascii?Q?BSJZBJ70QLGZLF3sUvK+B9dlVGV1qZTWVl9Zn40jpGe7PltvzdeTJQ5Ky881?= =?us-ascii?Q?P4PNMGu00BEbJlprt+P+8G4BcqEFeHYWXzRTLYB91SVAKyvBs7Tsmz433ZMP?= =?us-ascii?Q?ffidDvj0fV3TNgFehc6kPiuWfjuoYGwhRr3h+cEl6heS9q9tjEHFvvHTn9l0?= =?us-ascii?Q?9aMscCGacXt0RqlwdrmgkKNPFXX0+8tS6Up5Y5IbyDFThWOynivvgIqm8b4s?= =?us-ascii?Q?FDyaMpF76OwrGaiJBZxs8BrxAu8wCNm2NpiIIe41bdfxgbqfatOSFOumxCY9?= =?us-ascii?Q?BCFKle+I/DHsAosjRS+MpmjmA984nkv?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1076;6:3+CN1txi8NiXKTDzNogwhuqYbkW0mVFcDJDiznbciJDLO3D8bWrPYlqlVtTXqeXaH43HGyVZwCf66j29MWmpu9wwd15SpJ5sOwdBg0GQmMyAX1uSe1fm1Qnf9qSM8qxUztrAH/mELBtsENWa4ZTA2ORCyPtuaZupNEzNytFUfIbfK6qZe3EhI023F2OXgVDQDkfr+SR0ujCndftMQUJ4krdJpAcGJ/esXlXkbJ0lBlBe3R/UR1zyoQz1A082qggPL+x3lZDtoSdYI5vldb39mZU/vLOVOchl+QQ/pn0VAWxn6QyvBvLIYXTgP4nVEmiMOa+9aGjD1HmrEX9jfq/jd9/T9Tk1x/bwk7Ac+dl9Ng4=;5:6woH4aGxJHZUOxl7E2voof94KdOCaz3YZGGk51CUhE4lZWC+Ca9eb13u6M1vsmscsBOoQyb6oZz1IqYlWEvOB4Y8b/ku2t2bDh8DB/W8xAccO5rDVH6n6qy0RXYy4rwmKd5t18GmsTc5R8PmaRsPvV81Hp1RU0qKnH27CJbxrNU=;24:OBZw+/Cbc2Tm0pNRIs5F9txWh5zQiROaL08RFrut6cnOmtRLMx3LQ9jkdjpGGofBANlVcRiO7ncFaD5IohNGWoKwD7/Wm/AON8W20MhDitI=;7:zbiCjAGiZYeDAhfZFlVnOed/BKN6Ger5I16a9lCXHGCuaMHnrdADGqH++mEx07srZNHPG7q0iAav6vXC2prFb7NMna80/Cc1uheJIz3eCLGWVN9DllpG8CltDAeNdyeiYI7mttQqiZJDTZicyXaLC4S1l8jSNraTyBtBy4wvP31zGJeNvQY95Kzvx5nWcuIqzypegDlVpRlPgUJ7UwrvEXym6kl5xPkXhdi+645BOlGKmith6/kBbLB5v5BVSj98 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1076;20:l25MAXUNayosVSTkUUjB+TnfD/HavJMYGlcdhp4VpUe3HuoQC4HVWnbI+NetZNG9LXk07pXwHoF0ILOUSTkc0RgL/l+VzQaShMY4S9tjzpmnVhJrj948kD1J7WklZDCH9Mfo2oiqMF5EMsyD80t7gVAzXiW9rHTfEC1gULAYXn8= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2017 20:06:23.9808 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 36aa2299-1ce2-44c0-0e72-08d5222d31b7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR15MB1076 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-02_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 02, 2017 at 10:54:12AM -0700, Joe Perches wrote: > On Thu, 2017-11-02 at 13:15 -0400, Roman Gushchin wrote: > > Rename device type and access type constants defined in > > security/device_cgroup.c by adding the DEVCG_ prefix. > > > > The reason behind this renaming is to make them global namespace > > friendly, as they will be moved to the corresponding header file > > by following patches. > [] > > diff --git a/security/device_cgroup.c b/security/device_cgroup.c > [] > > @@ -14,14 +14,14 @@ > > #include > > #include > > > > -#define ACC_MKNOD 1 > > -#define ACC_READ 2 > > -#define ACC_WRITE 4 > > -#define ACC_MASK (ACC_MKNOD | ACC_READ | ACC_WRITE) > > +#define DEVCG_ACC_MKNOD 1 > > +#define DEVCG_ACC_READ 2 > > +#define DEVCG_ACC_WRITE 4 > > +#define DEVCG_ACC_MASK (DEVCG_ACC_MKNOD | DEVCG_ACC_READ | DEVCG_ACC_WRITE) > > trivia: > > major and minor are u32 but all the > type and access uses seem to be "short" > > Perhaps u16 (or __u16 if uapi public) instead? It was so for a while, and it doesn't seem to be related with this patchset. So, I'd prefer to change this in a separate patch. Thanks!