linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: Guenter Roeck <linux@roeck-us.net>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: pcwd_pci: mark expected switch fall-through
Date: Fri, 03 Nov 2017 10:47:37 -0500	[thread overview]
Message-ID: <20171103104737.Horde.jIupkyXRbKxDR--eHgm0-aF@gator4166.hostgator.com> (raw)
In-Reply-To: <20171103150423.GA10138@infomag.iguana.be>

Hi Wim,

Quoting Wim Van Sebroeck <wim@iguana.be>:

> Hi Gustavo,
>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Notice that in this particular case I replaced "Fall" with a proper
>> "fall through" comment, which is what GCC is expecting to find.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>>  drivers/watchdog/pcwd_pci.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/pcwd_pci.c b/drivers/watchdog/pcwd_pci.c
>> index c0d07ee..c882252 100644
>> --- a/drivers/watchdog/pcwd_pci.c
>> +++ b/drivers/watchdog/pcwd_pci.c
>> @@ -545,7 +545,7 @@ static long pcipcwd_ioctl(struct file *file,  
>> unsigned int cmd,
>>  			return -EINVAL;
>>
>>  		pcipcwd_keepalive();
>> -		/* Fall */
>> +		/* fall through */
>>  	}
>>
>>  	case WDIOC_GETTIMEOUT:
>> --
>> 2.7.4
>>
>
> Shouldn't the /* fall through */ come after the } ?
>

Yep, you are right.

I'll fix that.

Thank you!
--
Gustavo A. R. Silva

> Kind regards,
> Wim.

  reply	other threads:[~2017-11-03 15:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 14:49 [PATCH] watchdog: pcwd_pci: mark expected switch fall-through Gustavo A. R. Silva
2017-11-03 15:04 ` Wim Van Sebroeck
2017-11-03 15:47   ` Gustavo A. R. Silva [this message]
2017-11-03 16:02     ` [PATCH v2] " Gustavo A. R. Silva
2017-11-05 15:11       ` [v2] " Guenter Roeck
2017-11-03 15:54   ` [PATCH] " Guenter Roeck
2017-11-03 15:57     ` Gustavo A. R. Silva
2017-11-03 16:02     ` Joe Perches
2017-11-03 16:15       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171103104737.Horde.jIupkyXRbKxDR--eHgm0-aF@gator4166.hostgator.com \
    --to=garsilva@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).