From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752968AbdKCPFL (ORCPT ); Fri, 3 Nov 2017 11:05:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52002 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751303AbdKCPFJ (ORCPT ); Fri, 3 Nov 2017 11:05:09 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5C0637E421 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Fri, 3 Nov 2017 16:05:05 +0100 From: Jiri Olsa To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com, kan.liang@intel.com, Stephane Eranian Subject: Re: [PATCH v2 2/5] perf/x86: add PERF_SAMPLE_SKID_IP support for X86 PEBS Message-ID: <20171103150505.GB32113@krava> References: <1509646559-919-1-git-send-email-eranian@google.com> <1509646559-919-3-git-send-email-eranian@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509646559-919-3-git-send-email-eranian@google.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 03 Nov 2017 15:05:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 02, 2017 at 11:15:56AM -0700, Stephane Eranian wrote: > From: Stephane Eranian > > This atch adds support for SKID_IP to Intel x86 processors in PEBS > mode. s/atch/patch/ > > Signed-off-by: Stephane Eranian > --- > arch/x86/events/intel/ds.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c > index e1965e5ff570..b7afdf88f441 100644 > --- a/arch/x86/events/intel/ds.c > +++ b/arch/x86/events/intel/ds.c > @@ -1189,6 +1189,13 @@ static void setup_pebs_sample_data(struct perf_event *event, > x86_pmu.intel_cap.pebs_format >= 1) > data->addr = pebs->dla; > > + /* > + * unmodified, skid IP which is guaranteed to be the next > + * dyanmic instruction > + */ s/dyanmic/dynamic/ jirka > + if (sample_type & PERF_SAMPLE_SKID_IP) > + data->skid_ip = pebs->ip; > + > if (x86_pmu.intel_cap.pebs_format >= 2) { > /* Only set the TSX weight when no memory weight. */ > if ((sample_type & PERF_SAMPLE_WEIGHT) && !fll) > -- > 2.7.4 >