From: Mark Rutland <mark.rutland@arm.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Matthias Kaehlcke <mka@chromium.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Kees Cook <keescook@chromium.org>,
Greg Hackmann <ghackmann@google.com>
Subject: Re: [PATCH 07/15] arm64: use -mno-implicit-float instead of -mgeneral-regs-only
Date: Fri, 3 Nov 2017 18:02:57 +0000 [thread overview]
Message-ID: <20171103180257.e52r2qdeeg4m4l5p@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20171103171203.107569-9-samitolvanen@google.com>
On Fri, Nov 03, 2017 at 10:11:52AM -0700, Sami Tolvanen wrote:
> From: Greg Hackmann <ghackmann@google.com>
>
> LLVM bug 30792 causes clang's AArch64 backend to crash compiling
> arch/arm64/crypto/aes-ce-cipher.c. Replacing -mgeneral-regs-only with
> -mno-implicit-float is the suggested workaround.
>
> Signed-off-by: Greg Hackmann <ghackmann@google.com>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Ah, so I guess this is what I was hitting when testing with clang 5.0.0.
I was under the impression that this series was jsut enablnig LTO
support, not clang support generally.
It would be much nicer if we could depend on a fixed clang to start
with...
Thanks,
Mark.
> ---
> arch/arm64/Makefile | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index 939b310913cf..eb6f3c9ec6cb 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -45,7 +45,13 @@ $(warning Detected assembler with broken .inst; disassembly will be unreliable)
> endif
> endif
>
> -KBUILD_CFLAGS += -mgeneral-regs-only $(lseinstr) $(brokengasinst)
> +ifeq ($(cc-name),clang)
> +# This is a workaround for https://bugs.llvm.org/show_bug.cgi?id=30792.
> +KBUILD_CFLAGS += -mno-implicit-float
> +else
> +KBUILD_CFLAGS += -mgeneral-regs-only
> +endif
> +KBUILD_CFLAGS += $(lseinstr) $(brokengasinst)
> KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
> KBUILD_CFLAGS += $(call cc-option, -mpc-relative-literal-loads)
> KBUILD_AFLAGS += $(lseinstr) $(brokengasinst)
> --
> 2.15.0.403.gc27cc4dac6-goog
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-11-03 18:03 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 17:11 [PATCH 00/15] Add support for clang LTO Sami Tolvanen
2017-11-03 17:11 ` [PATCH 01/15] kbuild: add ld-name macro and support for GNU gold Sami Tolvanen
2017-11-03 18:24 ` Nick Desaulniers
2017-11-03 17:11 ` [PATCH 02/15] kbuild: fix LD_DEAD_CODE_DATA_ELIMINATION with " Sami Tolvanen
2017-11-03 17:11 ` [PATCH 03/15] kbuild: add support for clang LTO Sami Tolvanen
2017-11-03 17:11 ` [PATCH 04/15] kbuild: fix dynamic ftrace with " Sami Tolvanen
2017-11-03 17:11 ` [PATCH 05/15] scripts/mod: disable LTO for empty.c Sami Tolvanen
2017-11-03 17:11 ` [PATCH 06/15] efi/libstub: disable clang LTO Sami Tolvanen
2017-11-03 20:10 ` Ard Biesheuvel
2017-11-03 17:11 ` [PATCH 06/15] efi/libstub: disable LTO Sami Tolvanen
2017-11-03 17:11 ` [PATCH 07/15] arm64: use -mno-implicit-float instead of -mgeneral-regs-only Sami Tolvanen
2017-11-03 17:50 ` Nick Desaulniers
2017-11-03 18:02 ` Mark Rutland [this message]
2017-11-03 18:20 ` Nick Desaulniers
2017-11-03 18:31 ` Mark Rutland
2017-11-03 18:52 ` Mark Rutland
2017-11-03 19:06 ` Kees Cook
2017-11-03 20:18 ` Sami Tolvanen
2017-11-03 17:11 ` [PATCH 08/15] arm64: don't pass -maarch64linux to GNU gold Sami Tolvanen
2017-11-03 20:41 ` Yury Norov
2017-11-06 16:56 ` Sami Tolvanen
2017-11-03 17:11 ` [PATCH 09/15] arm64: keep .altinstructions and .altinstr_replacement Sami Tolvanen
2017-11-03 18:40 ` Nick Desaulniers
2017-11-03 17:11 ` [PATCH 10/15] arm64: disable ARM64_ERRATUM_843419 for clang LTO Sami Tolvanen
2017-11-03 20:13 ` Ard Biesheuvel
2017-11-09 18:54 ` Sami Tolvanen
2017-11-03 17:11 ` [PATCH 11/15] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold Sami Tolvanen
2017-11-03 17:11 ` [PATCH 11/15] arm64: fix mrs_s/msr_s macros for clang LTO Sami Tolvanen
2017-11-03 17:11 ` [PATCH 12/15] arm64: add a workaround for GNU gold with ARM64_MODULE_PLTS Sami Tolvanen
2017-11-03 17:11 ` [PATCH 12/15] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold Sami Tolvanen
2017-11-03 17:12 ` [PATCH 13/15] arm64: add a workaround for GNU gold with ARM64_MODULE_PLTS Sami Tolvanen
2017-11-03 20:09 ` Ard Biesheuvel
2017-11-03 20:29 ` Sami Tolvanen
2017-11-03 17:12 ` [PATCH 13/15] arm64: fix mrs_s/msr_s macros for clang LTO Sami Tolvanen
2017-11-03 17:53 ` Nick Desaulniers
2017-11-03 18:06 ` Mark Rutland
2017-11-03 18:15 ` Nick Desaulniers
2017-11-03 18:38 ` Mark Rutland
2017-11-08 9:25 ` Yury Norov
2017-11-09 0:02 ` Andi Kleen
2017-11-09 4:48 ` Maxim Kuvyrkov
2017-11-09 16:51 ` Sami Tolvanen
2017-11-09 16:50 ` Sami Tolvanen
2017-11-09 16:45 ` Sami Tolvanen
2017-11-03 17:12 ` [PATCH 14/15] arm64: crypto: disable LTO for aes-ce-cipher.c Sami Tolvanen
2017-11-03 20:10 ` Ard Biesheuvel
2017-11-03 17:12 ` [PATCH 15/15] arm64: select ARCH_SUPPORTS_CLANG_LTO Sami Tolvanen
2017-11-03 17:51 ` [PATCH 00/15] Add support for clang LTO Mark Rutland
2017-11-03 18:07 ` Nick Desaulniers
2017-11-03 18:29 ` Mark Rutland
2017-11-03 18:36 ` Nick Desaulniers
2017-11-03 18:49 ` Mark Rutland
2017-11-03 18:07 ` Matthias Kaehlcke
2017-11-03 18:09 ` Mark Rutland
2017-11-03 18:11 ` Nick Desaulniers
2017-11-03 19:26 ` Mark Rutland
2017-11-03 19:56 ` Sami Tolvanen
2017-11-04 2:13 ` Mark Rutland
2017-11-09 10:54 ` AKASHI Takahiro
2017-11-09 11:03 ` Marc Zyngier
2017-11-09 16:31 ` Sami Tolvanen
2017-11-03 20:23 ` Ard Biesheuvel
2017-11-03 18:22 ` Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103180257.e52r2qdeeg4m4l5p@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=ghackmann@google.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=ndesaulniers@google.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).