* [PATCH] PM / devfreq: Propagate error from devfreq_add_device()
@ 2017-11-04 3:38 ` Bjorn Andersson
2017-11-05 22:41 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Andersson @ 2017-11-04 3:38 UTC (permalink / raw)
To: MyungJoo Ham, Kyungmin Park, Chanwoo Choi; +Cc: linux-pm, linux-kernel
Propagate the error of devfreq_add_device() in devm_devfreq_add_device()
rather than statically returning ENOMEM. This makes it slightly faster
to pinpoint the cause of a returned error.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/devfreq/devfreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 78fb496ecb4e..99c4021fc33b 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -737,7 +737,7 @@ struct devfreq *devm_devfreq_add_device(struct device *dev,
devfreq = devfreq_add_device(dev, profile, governor_name, data);
if (IS_ERR(devfreq)) {
devres_free(ptr);
- return ERR_PTR(-ENOMEM);
+ return devfreq;
}
*ptr = devfreq;
--
2.12.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / devfreq: Propagate error from devfreq_add_device()
2017-11-04 3:38 ` [PATCH] PM / devfreq: Propagate error from devfreq_add_device() Bjorn Andersson
@ 2017-11-05 22:41 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2017-11-05 22:41 UTC (permalink / raw)
To: Bjorn Andersson, MyungJoo Ham, Kyungmin Park; +Cc: linux-pm, linux-kernel
Hi,
On 2017년 11월 04일 12:38, Bjorn Andersson wrote:
> Propagate the error of devfreq_add_device() in devm_devfreq_add_device()
> rather than statically returning ENOMEM. This makes it slightly faster
> to pinpoint the cause of a returned error.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/devfreq/devfreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 78fb496ecb4e..99c4021fc33b 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -737,7 +737,7 @@ struct devfreq *devm_devfreq_add_device(struct device *dev,
> devfreq = devfreq_add_device(dev, profile, governor_name, data);
> if (IS_ERR(devfreq)) {
> devres_free(ptr);
> - return ERR_PTR(-ENOMEM);
> + return devfreq;
> }
>
> *ptr = devfreq;
>
Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
But, you better to send this patch to the 'stable@vger.kernel.org'
with the fixes information as following:
Fixes: 8cd84092d35e ("PM / devfreq: Add resource-managed function for devfreq device")
Cc: stable@vger.kernel.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-05 22:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20171104033835epcas3p2a0e62915bf40aab150c78b4a3d341b13@epcas3p2.samsung.com>
2017-11-04 3:38 ` [PATCH] PM / devfreq: Propagate error from devfreq_add_device() Bjorn Andersson
2017-11-05 22:41 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).