From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: make PREEMPTIRQ_EVENTS depend on TRACING
Date: Sat, 4 Nov 2017 05:58:02 +0900 [thread overview]
Message-ID: <20171104055802.ce04eeab4849b09bc8c0295e@kernel.org> (raw)
In-Reply-To: <20171103104031.270375-1-arnd@arndb.de>
On Fri, 3 Nov 2017 11:39:57 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> When CONFIG_TRACING is disabled, the new preemptirq events tracer
> produces a build failure:
>
> In file included from kernel/trace/trace_irqsoff.c:17:0:
> kernel/trace/trace.h: In function 'trace_test_and_set_recursion':
> kernel/trace/trace.h:542:28: error: 'struct task_struct' has no member named 'trace_recursion'
>
> Adding an explicit dependency avoids the broken configuration.
>
> Fixes: d59158162e03 ("tracing: Add support for preempt and irq enable/disable events")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> No idea if this is the best solution, it just happened to fix the build
> failure for me.
OK, as same as other tracers, it should select GENERIC_TRACER and TRACER_MAX_TRACE,
and depends on TRACE_IRQFLAGS_SUPPORT, and maybe depends on !ARCH_USES_GETTIMEOFFSET.
Thank you,
> ---
> kernel/trace/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 1ff10ca078d6..c8c18c793c86 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -164,6 +164,7 @@ config PREEMPTIRQ_EVENTS
> bool "Enable trace events for preempt and irq disable/enable"
> select TRACE_IRQFLAGS
> depends on DEBUG_PREEMPT || !PROVE_LOCKING
> + depends on TRACING
> default n
> help
> Enable tracing of disable and enable events for preemption and irqs.
> --
> 2.9.0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2017-11-03 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 10:39 [PATCH] tracing: make PREEMPTIRQ_EVENTS depend on TRACING Arnd Bergmann
2017-11-03 20:58 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171104055802.ce04eeab4849b09bc8c0295e@kernel.org \
--to=mhiramat@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).