From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756572AbdKDKj7 (ORCPT <rfc822;w@1wt.eu>);
        Sat, 4 Nov 2017 06:39:59 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:38248 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752153AbdKDKj6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 4 Nov 2017 06:39:58 -0400
Date: Sat, 4 Nov 2017 11:40:10 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Philippe Ombredanne <pombredanne@nexb.com>
Subject: Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in
 drivers/usb/
Message-ID: <20171104104010.GA27490@kroah.com>
References: <20171019083832.GA21820@kroah.com>
 <20171103102830.GA18343@kroah.com>
 <20171103165301.GR7223@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171103165301.GR7223@localhost>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 03, 2017 at 05:53:01PM +0100, Johan Hovold wrote:
> On Fri, Nov 03, 2017 at 11:28:30AM +0100, Greg Kroah-Hartman wrote:
> > It's good to have SPDX identifiers in all files to make it easier to
> > audit the kernel tree for correct licenses.
> > 
> > Update the drivers/usb/ and include/linux/usb* files with the correct
> > SPDX license identifier based on the license text in the file itself.
> > The SPDX identifier is a legally binding shorthand, which can be used
> > instead of the full boiler plate text.
> > 
> > This work is based on a script and data from Thomas Gleixner, Philippe
> > Ombredanne, and Kate Stewart.
> > 
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Kate Stewart <kstewart@linuxfoundation.org>
> > Cc: Philippe Ombredanne <pombredanne@nexb.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> For USB serial:
> 
> Acked-by: Johan Hovold <johan@kernel.org>

Great, thanks for the ack.

> I noticed several MODULE_LICENSE macros which did not match the headers
> (e.g. "GPL" being used for version 2 only modules) for which I'll send a
> follow-up patch.
> 
> Someone should probably write a script for that once the SPDX
> identifiers are in.

Yes, I think that someone might have a script for that, it will be much
easier to detect these things now.  The issue is that the "v2" marking
came after the original "GPL" marking for MODULE_LICENSE() from what I
remember, so many of those will be wrong.

thanks,

greg k-h