linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Rob Herring <robh@kernel.org>,
	cphealy@gmail.com, Guenter Roeck <linux@roeck-us.net>,
	Lucas Stach <l.stach@pengutronix.de>,
	Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
	Lee Jones <lee.jones@linaro.org>, Pavel Machek <pavel@ucw.cz>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH v10 1/5] serdev: Make .remove in struct serdev_device_driver optional
Date: Sat, 4 Nov 2017 18:05:48 +0100	[thread overview]
Message-ID: <20171104170548.vkkgp363k2piyufx@earth> (raw)
In-Reply-To: <20171104112431.GA24583@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

Hi Greg,

On Sat, Nov 04, 2017 at 12:24:31PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Oct 31, 2017 at 09:36:52AM -0700, Andrey Smirnov wrote:
> > Using devres infrastructure it is possible to write a serdev driver
> > that doesn't have any code that needs to be called as a part of
> > .remove. Add code to make .remove optional.
> 
> What about manual unbind from userspace through sysfs?  You need to have
> a remove function.  All drivers need that, to not have it is pretty lazy :)

Resources,that have been requested via devres are free'd by the
devres framework after the driver specific remove function. This
also works for manual unbind.

If *all* driver resources are allocated using devres, you will end
up with an empty remove function. In that case it makes sense to
remove it completly. This is what quite a few (mainline) i2c and
spi drivers actually do.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-11-04 17:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 16:36 [PATCH v10 0/5] ZII RAVE platform driver Andrey Smirnov
2017-10-31 16:36 ` [PATCH v10 1/5] serdev: Make .remove in struct serdev_device_driver optional Andrey Smirnov
2017-11-01 23:48   ` Rob Herring
2017-11-04 11:24   ` Greg Kroah-Hartman
2017-11-04 17:05     ` Sebastian Reichel [this message]
2017-10-31 16:36 ` [PATCH v10 2/5] serdev: Introduce devm_serdev_device_open() Andrey Smirnov
2017-11-01 23:48   ` Rob Herring
2017-11-05 15:38   ` Johan Hovold
2017-11-05 22:19     ` Andrey Smirnov
2017-10-31 16:36 ` [PATCH v10 3/5] mfd: Add driver for RAVE Supervisory Processor Andrey Smirnov
2017-11-05 15:38   ` Johan Hovold
2017-11-05 22:02     ` Andrey Smirnov
2017-10-31 16:36 ` [PATCH v10 4/5] watchdog: Add RAVE SP watchdog driver Andrey Smirnov
2017-10-31 17:21   ` Guenter Roeck
2017-11-04 11:24   ` Greg Kroah-Hartman
2017-11-05 15:55     ` Guenter Roeck
2017-11-05 15:47   ` Johan Hovold
2017-11-05 18:34     ` Guenter Roeck
2017-11-05 21:59     ` Andrey Smirnov
2017-10-31 16:36 ` [PATCH v10 5/5] dt-bindings: watchdog: Add bindings for " Andrey Smirnov
2017-10-31 17:22   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171104170548.vkkgp363k2piyufx@earth \
    --to=sebastian.reichel@collabora.co.uk \
    --cc=andrew.smirnov@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=cphealy@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=l.stach@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nikita.yoush@cogentembedded.com \
    --cc=pavel@ucw.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).