From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751779AbdKFIL3 (ORCPT ); Mon, 6 Nov 2017 03:11:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53436 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbdKFIL2 (ORCPT ); Mon, 6 Nov 2017 03:11:28 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2EDBC49035 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=benjamin.tissoires@redhat.com Date: Mon, 6 Nov 2017 09:11:20 +0100 From: Benjamin Tissoires To: =?utf-8?Q?S=C3=A9bastien?= Szymanski Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , Julien Boibessot Subject: Re: [PATCH 3/3] HID: cp2112: fix broken gpio_direction_input callback Message-ID: <20171106081120.GC9728@mail.corp.redhat.com> References: <1509621164-28830-1-git-send-email-sebastien.szymanski@armadeus.com> <1509621164-28830-3-git-send-email-sebastien.szymanski@armadeus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1509621164-28830-3-git-send-email-sebastien.szymanski@armadeus.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 06 Nov 2017 08:11:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 02 2017 or thereabouts, Sébastien Szymanski wrote: > When everything goes smoothly, ret is set to 0 which makes the function > to return EIO error. > > Fixes: 8e9faa15469e ("HID: cp2112: fix gpio-callback error handling") > Signed-off-by: Sébastien Szymanski > --- > drivers/hid/hid-cp2112.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c > index 28e3c18..f7754a6 100644 > --- a/drivers/hid/hid-cp2112.c > +++ b/drivers/hid/hid-cp2112.c > @@ -205,12 +205,13 @@ static int cp2112_gpio_direction_input(struct gpio_chip *chip, unsigned offset) > ret = hid_hw_raw_request(hdev, CP2112_GPIO_CONFIG, buf, > CP2112_GPIO_CONFIG_LENGTH, HID_FEATURE_REPORT, > HID_REQ_SET_REPORT); > - if (ret < 0) { > + if (ret != CP2112_GPIO_CONFIG_LENGTH) { Ack for this. > hid_err(hdev, "error setting GPIO config: %d\n", ret); > goto exit; > } > > - ret = 0; > + mutex_unlock(&dev->lock); > + return 0; Wouldn't it be better to just turn - return ret < 0 ? ret : -EIO; into + return ret <= 0 ? ret : -EIO; at the end of the function? I'd rather keep the same exit path in both cases, error or success. Cheers, Benjamin > > exit: > mutex_unlock(&dev->lock); > -- > 2.7.3 >