From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958AbdKFIM0 (ORCPT ); Mon, 6 Nov 2017 03:12:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37448 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737AbdKFIMZ (ORCPT ); Mon, 6 Nov 2017 03:12:25 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0253C356DE Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=benjamin.tissoires@redhat.com Date: Mon, 6 Nov 2017 09:12:20 +0100 From: Benjamin Tissoires To: =?utf-8?Q?S=C3=A9bastien?= Szymanski Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , Julien Boibessot Subject: Re: [PATCH 2/3] HID: cp2112: add HIDRAW dependency Message-ID: <20171106081220.GD9728@mail.corp.redhat.com> References: <1509621164-28830-1-git-send-email-sebastien.szymanski@armadeus.com> <1509621164-28830-2-git-send-email-sebastien.szymanski@armadeus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1509621164-28830-2-git-send-email-sebastien.szymanski@armadeus.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 06 Nov 2017 08:12:25 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 02 2017 or thereabouts, Sébastien Szymanski wrote: > Otherwise, with HIDRAW=n, the probe function crashes because of null > dereference of hdev->hidraw. > > Fixes: 42cb6b35b9e6 ("HID: cp2112: use proper hidraw name with minor number") > Signed-off-by: Sébastien Szymanski Patches 1 and 2 (only) are: Acked-by: Benjamin Tissoires > --- > drivers/hid/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index 374301f..8c7a0ce 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -230,7 +230,7 @@ config HID_CMEDIA > > config HID_CP2112 > tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support" > - depends on USB_HID && I2C && GPIOLIB > + depends on USB_HID && HIDRAW && I2C && GPIOLIB > select GPIOLIB_IRQCHIP > ---help--- > Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge. > -- > 2.7.3 >