From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933223AbdKGIZW (ORCPT ); Tue, 7 Nov 2017 03:25:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:37882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933049AbdKGIZV (ORCPT ); Tue, 7 Nov 2017 03:25:21 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C506721870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=leon@kernel.org Date: Tue, 7 Nov 2017 10:25:16 +0200 From: Leon Romanovsky To: "Gustavo A. R. Silva" Cc: Selvin Xavier , Devesh Sharma , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey Message-ID: <20171107082516.GD18825@mtr-leonro.local> References: <20171106143514.GA19786@embeddedor.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yudcn1FV7Hsu/q59" Content-Disposition: inline In-Reply-To: <20171106143514.GA19786@embeddedor.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yudcn1FV7Hsu/q59 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: > Check on return value and goto label mbx_err are unnecessary. > > Addresses-Coverity-ID: 1268780 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > index f8c14c7..db02bbb 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > @@ -1956,9 +1956,7 @@ int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev *dev, int fr_mr, u32 lkey) > cmd->lkey = lkey; > cmd->rsvd_frmr = fr_mr ? 1 : 0; > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd); > - if (status) > - goto mbx_err; > -mbx_err: > + Can you please remove assignment from "int status = -ENOMEM"? It produces warning too. Thanks > kfree(cmd); > return status; > } > -- > 2.7.4 > --yudcn1FV7Hsu/q59 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAloBbewACgkQ5GN7iDZy WKcY4w/+N8NXZgjpoSB4bzY1BTOjJ3rpNUzN/uMPe9PR772hwF9V3jIoMZm5XTpF hhrHgPjurC/7bX8kPGiFweMtE/jHqTPPx6nYZcGzek6OfdizyMV4NY8ZbzUIjBE3 GLJn3gc7rFF2ifDX+Ipl3uw9E+j0dDhcTrR9oiwnxefRjIP71eEgxRS1hCtFY/gk QIlHunR/5WrMi0mWgJ3pbBVd1eMPvvAwturIomdfog81wrLgnxoG10kZYapJ/MYA tAaumHYy0rPAYKFfi0UrNHoblJ47vSysDiLLEnIUYuQ1r27iTgx0ctU73JhmdFyu YzO7QiXd6Xtum3SytTqJP8FsnvCcjVzGUqwp6qUnNjknpSbJfZztWT5IKUZY3vfU MAqWz8klndpP+T7fbwidJP6AsBk9EOslehvNO53D1ej3Bl0OA1U2KyUFSN074BS0 p2wIVBhuuymT6iTSlw6K8hbw/rAMbGWy+/e0YPFNqfOv60hq3KfuinBLYceWKo2Y MpZPjj272RNlWCUgW6YxJrqOA0Vw+E4D/IjWfmTo3Nt99B6qA8OTBQJ9xOLHLtcp ObQhkItLPzZ4gfuP8ilfXFwf67PyiGh1mlR1aooqRYG4RiPhj3z4tsq/lWay05IQ FXMGRaL2cwJZ9pKXt4BL95WiIOuK37P4q5pEAs5Af9Nb65ph114= =3+We -----END PGP SIGNATURE----- --yudcn1FV7Hsu/q59--