linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: Selvin Xavier <selvin.xavier@broadcom.com>,
	Devesh Sharma <devesh.sharma@broadcom.com>,
	Doug Ledford <dledford@redhat.com>,
	Yuval Shaia <yuval.shaia@oracle.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
Date: Tue, 7 Nov 2017 16:50:18 +0200	[thread overview]
Message-ID: <20171107145018.GJ18825@mtr-leonro.local> (raw)
In-Reply-To: <20171107144517.GA25631@embeddedor.com>

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote:
> Check on return value and goto label mbx_err are unnecessary.
>
> Addresses-Coverity-ID: 1268780
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
> Changes in v2:
>  Remove assignment from "int status = -ENOMEM" as suggested by Leon Romanovsky.
>
>  drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Please use git send-email to send patches and not reply to the conversation.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-11-07 14:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 14:35 [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey Gustavo A. R. Silva
2017-11-07  6:31 ` Yuval Shaia
2017-11-07 14:27   ` Gustavo A. R. Silva
2017-11-07  8:25 ` Leon Romanovsky
2017-11-07 14:30   ` Gustavo A. R. Silva
2017-11-07 14:44     ` Leon Romanovsky
2017-11-07 14:45     ` [PATCH v2] " Gustavo A. R. Silva
2017-11-07 14:50       ` Leon Romanovsky [this message]
2017-11-07 14:56         ` Gustavo A. R. Silva
2017-11-07 16:28           ` Leon Romanovsky
2017-11-08 20:16             ` Gustavo A. R. Silva
2017-11-09  8:28               ` Leon Romanovsky
2017-11-13 21:19       ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171107145018.GJ18825@mtr-leonro.local \
    --to=leon@kernel.org \
    --cc=devesh.sharma@broadcom.com \
    --cc=dledford@redhat.com \
    --cc=garsilva@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=selvin.xavier@broadcom.com \
    --cc=yuval.shaia@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).