From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758079AbdKGQ2K (ORCPT ); Tue, 7 Nov 2017 11:28:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:35138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbdKGQ2I (ORCPT ); Tue, 7 Nov 2017 11:28:08 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C90EF217C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=leon@kernel.org Date: Tue, 7 Nov 2017 18:28:04 +0200 From: Leon Romanovsky To: "Gustavo A. R. Silva" Cc: Selvin Xavier , Devesh Sharma , Doug Ledford , Yuval Shaia , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey Message-ID: <20171107162804.GM18825@mtr-leonro.local> References: <20171107083022.Horde.E7wKXkvErbmdKSHiwomsj7N@gator4166.hostgator.com> <20171107144517.GA25631@embeddedor.com> <20171107145018.GJ18825@mtr-leonro.local> <20171107085637.Horde.qFzN3uJQkHeQUTyEgZzV4mv@gator4166.hostgator.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bgLLobvf7eP6VP5c" Content-Disposition: inline In-Reply-To: <20171107085637.Horde.qFzN3uJQkHeQUTyEgZzV4mv@gator4166.hostgator.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bgLLobvf7eP6VP5c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 07, 2017 at 08:56:37AM -0600, Gustavo A. R. Silva wrote: > > Quoting Leon Romanovsky : > > > On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote: > > > Check on return value and goto label mbx_err are unnecessary. > > > > > > Addresses-Coverity-ID: 1268780 > > > Signed-off-by: Gustavo A. R. Silva > > > Reviewed-by: Yuval Shaia > > > --- > > > Changes in v2: > > > Remove assignment from "int status = -ENOMEM" as suggested by Leon > > > Romanovsky. > > > > > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++---- > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > Please use git send-email to send patches and not reply to the conversation. > > > > I'm using mutt. > What would be the advantage of using git send-email in this case? New mail headers, so it won't appear as Reply-To and will be presented correctly in mutt's threaded mode. You can do it with mutt too. > > > Thanks, > > Reviewed-by: Leon Romanovsky > > Thank you > -- > Gustavo A. R. Silva > > > > > --bgLLobvf7eP6VP5c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAloB3xQACgkQ5GN7iDZy WKf/HQ/+LWE2OjgEi7vbj9fG4GW6Lwjrdc0CR9mscnh0kErEAAzATS2cnJ0l8/IO 7SE/wVg8N6qGGK/1y7jFywSLQCkoIsgNRltyP2d0nZ33eLqzrqn1yRrXEFhsAYIO kVEMZ1RiBN6HIKXQlmfhZaiWzzMj4/MQ0ekdCUYyc6VyyO7MG134rs1/bfkDcNr2 JGrOsH2/aNfMAI0IyYW1VvlYMwbDAoZYcNLOkI64Kzv3RKsaFIrrGCQCJB8WOn8Y tLB2khXEIx45WOoMpT7qQ9h1DETio5kUd5BabPvqbJDyOy8Rb/dZyltH8YcswZZ2 zshpqQn5COBOeCDPM6mOr4mSiDFPMx42ECxb53p8Fnwt+SJeUyZHMyLU3zzkCWC5 00DkM1XYnX6PXPb3MCzUi9pj9rb6nYmw3yppJRqk+mzuZnSYwYGqjEKNId27BED2 +cmyX1d/OBs5wp/ud24+5LPdpQuovYN7UAr6mclTaAd1cMu+tw2NZXwtQQL4bt+f iNjjnnnncTa06IFsGl6ivLlqnR/dxD+BUTJlZa/huVJJG3LLEhu38H1TIaX2ASJd rCXSxahHRh1mzRL/Ehv8c2U7vyJuEvx02QKH8DAdwQwy1eXuqhFFs1By9eZX8btg PfO2sr/cUyoI9NrxdiXkAUR44jZfC8mz8MYYabWJj+OTGQ+I/yI= =ERc0 -----END PGP SIGNATURE----- --bgLLobvf7eP6VP5c--