From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Baolin Wang <baolin.wang@spreadtrum.com>
Cc: a.zummo@towertech.it, robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org, broonie@kernel.org,
baolin.wang@linaro.org
Subject: Re: [PATCH 1/2] dt-bindings: rtc: Add Spreadtrum SC27xx RTC documentation
Date: Wed, 8 Nov 2017 04:15:20 +0100 [thread overview]
Message-ID: <20171108031520.zx2ipqugiyypmpms@piout.net> (raw)
In-Reply-To: <7037c5053a533505f38fc036290a398989cfdafc.1510051749.git.baolin.wang@spreadtrum.com>
Hi,
On 07/11/2017 at 19:34:07 +0800, Baolin Wang wrote:
> This patch adds the binding documentation for Spreadtrum SC27xx series
> RTC device.
>
> Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
> ---
> .../devicetree/bindings/rtc/sprd,sc27xx-rtc.txt | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/sprd,sc27xx-rtc.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/sprd,sc27xx-rtc.txt b/Documentation/devicetree/bindings/rtc/sprd,sc27xx-rtc.txt
> new file mode 100644
> index 0000000..971d3a2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/sprd,sc27xx-rtc.txt
> @@ -0,0 +1,16 @@
> +Spreadtrum SC27xx Real Time Clock
> +
> +Required properties:
> +- compatible: should be "sprd,sc27xx-rtc".
Don't use wildcards in a compatible, use a specific chip model. later
chips may or may not be compatible with that one.
> +- reg: address offset of rtc register.
> +- interrupt-parent: phandle for the interrupt controller.
> +- interrupts: rtc alarm interrupt.
> +
> +Example:
> +
> + rtc: rtc@280 {
The rtc: alias is probably useless
> + compatible = "sprd,sc27xx-rtc";
> + reg = <0x280>;
> + interrupt-parent = <&pmic>;
> + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> + };
I would include the parent MFD node too.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-11-08 3:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 11:34 [PATCH 1/2] dt-bindings: rtc: Add Spreadtrum SC27xx RTC documentation Baolin Wang
2017-11-07 11:34 ` [PATCH 2/2] rtc: sprd: Add Spreadtrum RTC driver Baolin Wang
2017-11-08 3:44 ` Alexandre Belloni
2017-11-08 5:29 ` Baolin Wang
2017-11-08 5:35 ` Alexandre Belloni
2017-11-08 5:48 ` Baolin Wang
2017-11-08 3:15 ` Alexandre Belloni [this message]
2017-11-08 5:02 ` [PATCH 1/2] dt-bindings: rtc: Add Spreadtrum SC27xx RTC documentation Baolin Wang
2017-11-08 5:12 ` Alexandre Belloni
2017-11-08 5:33 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108031520.zx2ipqugiyypmpms@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=baolin.wang@linaro.org \
--cc=baolin.wang@spreadtrum.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).