From: kbuild test robot <lkp@intel.com>
To: miles.chen@mediatek.com
Cc: kbuild-all@01.org, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org,
Miles Chen <miles.chen@mediatek.com>
Subject: Re: [PATCH] slub: Fix sysfs duplicate filename creation when slub_debug=O
Date: Wed, 8 Nov 2017 11:05:17 +0800 [thread overview]
Message-ID: <201711081033.ZKtNkeA7%fengguang.wu@intel.com> (raw)
In-Reply-To: <1510023934-17517-1-git-send-email-miles.chen@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 2520 bytes --]
Hi Miles,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mmotm/master]
[also build test ERROR on v4.14-rc8 next-20171107]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/miles-chen-mediatek-com/slub-Fix-sysfs-duplicate-filename-creation-when-slub_debug-O/20171108-100701
base: git://git.cmpxchg.org/linux-mmotm.git master
config: i386-randconfig-x001-201745 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
mm/slub.c: In function 'sysfs_slab_add':
>> mm/slub.c:5713:18: error: 'SLAB_NEVER_MERGE' undeclared (first use in this function)
(slub_debug & SLAB_NEVER_MERGE))
^~~~~~~~~~~~~~~~
mm/slub.c:5713:18: note: each undeclared identifier is reported only once for each function it appears in
vim +/SLAB_NEVER_MERGE +5713 mm/slub.c
5697
5698 static int sysfs_slab_add(struct kmem_cache *s)
5699 {
5700 int err;
5701 const char *name;
5702 struct kset *kset = cache_kset(s);
5703 int unmergeable = slab_unmergeable(s);
5704
5705 INIT_WORK(&s->kobj_remove_work, sysfs_slab_remove_workfn);
5706
5707 if (!kset) {
5708 kobject_init(&s->kobj, &slab_ktype);
5709 return 0;
5710 }
5711
5712 if (!unmergeable && disable_higher_order_debug &&
> 5713 (slub_debug & SLAB_NEVER_MERGE))
5714 unmergeable = 1;
5715
5716 if (unmergeable) {
5717 /*
5718 * Slabcache can never be merged so we can use the name proper.
5719 * This is typically the case for debug situations. In that
5720 * case we can catch duplicate names easily.
5721 */
5722 sysfs_remove_link(&slab_kset->kobj, s->name);
5723 name = s->name;
5724 } else {
5725 /*
5726 * Create a unique name for the slab as a target
5727 * for the symlinks.
5728 */
5729 name = create_unique_id(s);
5730 }
5731
5732 s->kobj.kset = kset;
5733 err = kobject_init_and_add(&s->kobj, &slab_ktype, NULL, "%s", name);
5734 if (err)
5735 goto out;
5736
5737 err = sysfs_create_group(&s->kobj, &slab_attr_group);
5738 if (err)
5739 goto out_del_kobj;
5740
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34116 bytes --]
prev parent reply other threads:[~2017-11-08 3:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 3:05 [PATCH] slub: Fix sysfs duplicate filename creation when slub_debug=O miles.chen
2017-11-07 15:22 ` Christopher Lameter
2017-11-08 5:32 ` Miles Chen
2017-11-08 15:05 ` Christopher Lameter
2017-11-09 8:52 ` Miles Chen
2017-11-09 15:49 ` Christopher Lameter
2017-11-09 23:51 ` Miles Chen
2017-11-10 16:02 ` Christopher Lameter
2017-11-12 1:40 ` Miles Chen
2017-11-08 3:05 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201711081033.ZKtNkeA7%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=miles.chen@mediatek.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).