From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752508AbdKHMpV (ORCPT ); Wed, 8 Nov 2017 07:45:21 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:42438 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752281AbdKHMpR (ORCPT ); Wed, 8 Nov 2017 07:45:17 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5564F6071F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: rtlwifi: remove redundant initialization to cfg_cmd From: Kalle Valo In-Reply-To: <20171104193759.919-1-colin.king@canonical.com> References: <20171104193759.919-1-colin.king@canonical.com> To: Colin Ian King Cc: Larry Finger , Chaoming Li , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20171108124517.3D1E2607A4@smtp.codeaurora.org> Date: Wed, 8 Nov 2017 12:45:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin Ian King wrote: > From: Colin Ian King > > cfg_cmd is initialized to zero and this value is never read, instead > it is over-written in the start of a do-while loop. Remove the > redundant initialization. Cleans up clang warning: > > drivers/net/wireless/realtek/rtlwifi/core.c:1750:22: warning: Value > stored to 'cfg_cmd' during its initialization is never read > > Signed-off-by: Colin Ian King > Acked-by: Larry Finger Patch applied to wireless-drivers-next.git, thanks. f80ead1cd5fa rtlwifi: remove redundant initialization to cfg_cmd -- https://patchwork.kernel.org/patch/10041685/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches