From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752558AbdKHUQ2 (ORCPT ); Wed, 8 Nov 2017 15:16:28 -0500 Received: from gateway32.websitewelcome.com ([192.185.145.102]:17129 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207AbdKHUQ0 (ORCPT ); Wed, 8 Nov 2017 15:16:26 -0500 Date: Wed, 08 Nov 2017 14:16:25 -0600 Message-ID: <20171108141625.Horde.KGzDIfS83FFw-l2cUJ_EO95@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Leon Romanovsky Cc: Selvin Xavier , Devesh Sharma , Doug Ledford , Yuval Shaia , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey References: <20171107083022.Horde.E7wKXkvErbmdKSHiwomsj7N@gator4166.hostgator.com> <20171107144517.GA25631@embeddedor.com> <20171107145018.GJ18825@mtr-leonro.local> <20171107085637.Horde.qFzN3uJQkHeQUTyEgZzV4mv@gator4166.hostgator.com> <20171107162804.GM18825@mtr-leonro.local> In-Reply-To: <20171107162804.GM18825@mtr-leonro.local> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Source-L: Yes X-Exim-ID: 1eCWlt-000xlS-5F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:42065 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 53 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Leon Romanovsky : > On Tue, Nov 07, 2017 at 08:56:37AM -0600, Gustavo A. R. Silva wrote: >> >> Quoting Leon Romanovsky : >> >> > On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote: >> > > Check on return value and goto label mbx_err are unnecessary. >> > > >> > > Addresses-Coverity-ID: 1268780 >> > > Signed-off-by: Gustavo A. R. Silva >> > > Reviewed-by: Yuval Shaia >> > > --- >> > > Changes in v2: >> > > Remove assignment from "int status = -ENOMEM" as suggested by Leon >> > > Romanovsky. >> > > >> > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++---- >> > > 1 file changed, 2 insertions(+), 4 deletions(-) >> > >> > Please use git send-email to send patches and not reply to the >> conversation. >> > >> >> I'm using mutt. >> What would be the advantage of using git send-email in this case? > > New mail headers, so it won't appear as Reply-To and will be presented > correctly in mutt's threaded mode. > Oh I actually did that on purpose. So the preferred way to do this is to send the vN of the patch as a reply to the first patch? or as a new thread? Thanks -- Gustavo A. R. Silva