From: "Andrew F. Davis" <afd@ti.com>
To: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <kernel@pengutronix.de>
Cc: <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, "Andrew F . Davis" <afd@ti.com>
Subject: [PATCH 0/9] Remove use of "gpio-reset" from DT
Date: Wed, 8 Nov 2017 15:24:56 -0600 [thread overview]
Message-ID: <20171108212505.28320-1-afd@ti.com> (raw)
Hello all,
I was working on fixing up the tlv320aic31xx driver when I noticed
its gpio reset was not working, it was due to this driver looking
for "gpio-reset" instead of the usual "reset-gpio". A quick check
shows this mistake is rare and only copied by one other audio CODECs:
$ git grep "reset-gpio" | wc -l
630
$ git grep "gpio-reset" | wc -l
6
Luckliy the two effected drivers only use this reset line when power
has been cut to the device, so not only were these optional
properties but they had no real functional effect anyway. Lets
just fix this typo before is spreads to drivers were it matters.
I've also added fixes tags to each patch so it can be individually
back-ported to where this bug was introduced if one wanted to. I'm
hoping this can sit on next for a while to get the most testing,
just in case I'm wrong about this not breaking anything :)
Thanks,
Andrew
Andrew F. Davis (9):
ASoC: tlv320aic31xx: Fix typo in DT binding documentation
ASoC: tlv320aic3x: Fix typo in DT binding documentation
ASoC: cs42l56: bindings: sound: Fix reset GPIO name in example DT
binding
ARM: dts: am335x-pepper: Fix the audio CODEC's reset pin
ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin
ARM: dts: imx: Fix the audio CODEC's reset pin
ARM: dts: omap3-n900: Fix the audio CODEC's reset pin
ASoC: tlv320aic31xx: Fix the reset GPIO OF name
ASoC: tlv320aic3x: Fix the reset GPIO OF name
Documentation/devicetree/bindings/sound/cs42l56.txt | 2 +-
Documentation/devicetree/bindings/sound/tlv320aic31xx.txt | 5 ++++-
Documentation/devicetree/bindings/sound/tlv320aic3x.txt | 6 +++++-
arch/arm/boot/dts/am335x-pepper.dts | 2 +-
arch/arm/boot/dts/imx6qdl-gw5903.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
arch/arm/boot/dts/omap3-n900.dts | 4 ++--
sound/soc/codecs/tlv320aic31xx.c | 2 +-
sound/soc/codecs/tlv320aic3x.c | 2 +-
9 files changed, 18 insertions(+), 11 deletions(-)
--
2.15.0
next reply other threads:[~2017-11-08 21:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 21:24 Andrew F. Davis [this message]
2017-11-08 21:24 ` [PATCH 1/9] ASoC: tlv320aic31xx: Fix typo in DT binding documentation Andrew F. Davis
2017-11-09 14:25 ` Philipp Zabel
2017-11-09 16:28 ` Andrew F. Davis
2017-11-08 21:24 ` [PATCH 2/9] ASoC: tlv320aic3x: " Andrew F. Davis
2017-11-09 20:26 ` [alsa-devel] " Benoît Thébaudeau
2017-11-09 20:42 ` Andrew F. Davis
2017-11-08 21:24 ` [PATCH 3/9] ASoC: cs42l56: bindings: sound: Fix reset GPIO name in example DT binding Andrew F. Davis
2017-11-13 21:20 ` Rob Herring
2017-11-08 21:25 ` [PATCH 4/9] ARM: dts: am335x-pepper: Fix the audio CODEC's reset pin Andrew F. Davis
2017-11-09 14:25 ` Philipp Zabel
2017-11-09 16:40 ` Andrew F. Davis
2017-11-08 21:25 ` [PATCH 5/9] ARM: dts: imx6: RDU2: " Andrew F. Davis
2017-11-08 21:25 ` [PATCH 6/9] ARM: dts: imx: " Andrew F. Davis
2017-11-08 21:25 ` [PATCH 7/9] ARM: dts: omap3-n900: " Andrew F. Davis
2017-11-08 21:25 ` [PATCH 8/9] ASoC: tlv320aic31xx: Fix the reset GPIO OF name Andrew F. Davis
2017-11-08 21:36 ` Mark Brown
2017-11-08 21:53 ` Andrew F. Davis
2017-11-08 22:18 ` Mark Brown
2017-11-08 23:25 ` Andrew F. Davis
2017-11-09 13:22 ` Mark Brown
2017-11-08 21:25 ` [PATCH 9/9] ASoC: tlv320aic3x: " Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108212505.28320-1-afd@ti.com \
--to=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).