From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752625AbdKHTfw (ORCPT ); Wed, 8 Nov 2017 14:35:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59158 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752465AbdKHTfu (ORCPT ); Wed, 8 Nov 2017 14:35:50 -0500 Date: Wed, 8 Nov 2017 21:35:48 +0200 From: "Michael S. Tsirkin" To: Christian Borntraeger Cc: Cornelia Huck , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Martin Schwidefsky , Heiko Carstens , linux-s390@vger.kernel.org Subject: Re: [PATCH v2] s390/virtio: mark headers as BSD licensed Message-ID: <20171108213424-mutt-send-email-mst@kernel.org> References: <1510160307-13235-1-git-send-email-mst@redhat.com> <9c2debae-5c00-75ad-bc4d-13af9c4f431d@de.ibm.com> <20171108191531.2d2f7210.cohuck@redhat.com> <7ab1b0f9-6db2-1d49-3bc6-320e95c71d5b@de.ibm.com> <5ea37f22-920e-adc9-e7cf-f901faac92db@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ea37f22-920e-adc9-e7cf-f901faac92db@de.ibm.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 08 Nov 2017 19:35:49 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 08, 2017 at 07:57:28PM +0100, Christian Borntraeger wrote: > So what about the following > > - leave kvm_virtio.h unchanged and we will delete this file via the s390 tree Seems to be used by kvm_virtio.c - are you removing that too? > - change virtio_ccw.h to BSD license. The content of this file is really really trivial > and it boils down to 2 defines, that can be easily reconstructed by looking at the virtio spec. > Not even sure if something like this can be copyrighted. Yes. What prompted this was Greg's patch. > > For reference the content of this file minus comments is > > - snip - > #define KVM_VIRTIO_CCW_RING_ALIGN 4096 > #define KVM_S390_VIRTIO_CCW_NOTIFY 3 > - snip - > > > On 11/08/2017 07:33 PM, Christian Borntraeger wrote: > > > > > > On 11/08/2017 07:15 PM, Cornelia Huck wrote: > >> On Wed, 8 Nov 2017 19:12:25 +0100his > >> Christian Borntraeger wrote: > >> > >>> On 11/08/2017 05:59 PM, Michael S. Tsirkin wrote: > >>>> Virtio UAPI headers aren't just for UAPI, it's for guests/hypervisors as > >>>> well. The s390 ones need to be BSD as well. > >>>> > >>>> Fixes: e2be04c7f995 ("License cleanup: add SPDX license identifier to uapi header files with a license") > >>>> Cc: Greg Kroah-Hartman > >>>> Signed-off-by: Michael S. Tsirkin > >>>> --- > >>>> > >>>> since v1: > >>>> drop an extra comment chunk, reported by Cornelia > >>>> > >>>> arch/s390/include/uapi/asm/kvm_virtio.h | 26 +++++++++++++++++++++++++- > >>> > >>> FWIW, this file will go away anyway. > >>> Looks like the following commit in the s390 feature branch > >>> https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/drivers/s390/virtio/Makefile?h=features&id=7fb2b2d512448cf0e914c4647a1cf02b52263702 > >>> missed this file. > >> > >> Can we simply rip this out? > >> > >>> > >>> > >>> Regarding the virtio-ccw.h headers it is probably something that happened by accident. > >>> Back then Rusty (as an IBMer) proposed to change all virtio headers to BSD licence. > >> > >> ISTR that the relicensing already went through... is that not the case? > > > > The original kvm_virtio.h code was added in 2008 > > > > commit e976a2b997fc4ad70ccc53acfe62811c4aaec851 > > Author: Christian Borntraeger > > Date: Tue Mar 25 18:47:46 2008 +0100 > > > > s390: KVM guest: virtio device support, and kvm hypercalls > > > > > > > > > > The BSD re-licencing happened in 2008 > > > > commit 674bfc23c585b34c42263d73fb51710d49762a23 > > Author: Rusty Russell > > Date: Fri Jul 25 12:06:03 2008 -0500 > > > > virtio: clarify that ABI is usable by any implementations > > > > We want others to implement and use virtio, so it makes sense to BSD > > license the non-__KERNEL__ parts of the headers to make this crystal > > clear. > > > > and it seems that it missed arch/include/uapi/asm/kvm_virtio.h > > > > > > > > arch/include/uapi/asm/virtio_ccw.h probably just copied what > > kvm_virtio.h had in 2013. > > > > So its somewhat fair to assume that both files should be BSD, but they are not > > according to the licence statement. > > > > Gregs SPDX change just changed the GPL text in the header files to a SPDX > > statement. Now Michael wants to change this to BSD as it probably was intended > > but not written down. Sigh. > > > >> I thought this was just a fixup to align with reality? > >> > >>> > >>>> arch/s390/include/uapi/asm/virtio-ccw.h | 26 +++++++++++++++++++++++++- > >>>> 2 files changed, 50 insertions(+), 2 deletions(-) > >>