From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752839AbdKHWar (ORCPT ); Wed, 8 Nov 2017 17:30:47 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:56153 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbdKHWao (ORCPT ); Wed, 8 Nov 2017 17:30:44 -0500 X-Google-Smtp-Source: ABhQp+SCG24Bbtg0R/7EgCmE9qgOSE0OdN2t709IG281sIKVk/Mda9uA2GsKvvrcIIKOa7etkCcnYw== From: Rasmus Villemoes To: kernel-hardening@lists.openwall.com Cc: linux-kernel@vger.kernel.org, Andrew Morton , Kees Cook , Rasmus Villemoes Subject: [RFC 0/6] some compile- and run-time format checking Date: Wed, 8 Nov 2017 23:30:14 +0100 Message-Id: <20171108223020.24487-1-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Consider these strictly RFC/POC. I tried resurrecting my format_template plugin from two years ago, and it rebased pretty cleanly. It also compiles with gcc 6.3, and has the expected effect when one tries to trigger it, so it seems to work ok (I think there was some build bot issue back then, maybe there still is). The last four patches are something I threw together rather quickly. They compile and the few test cases pass, but I obviously need to find some places to actually use fmtcheck() to see if it's worth adding. Rasmus Villemoes (6): plugins: implement format_template attribute compiler.h: add __format_template compiler.h: add __attribute__((format_arg)) shorthand lib/vsprintf.c: add fmtcheck utility kernel.h: implement fmtmatch() wrapper around fmtcheck() lib/test_printf.c: add a few fmtcheck() test cases arch/Kconfig | 18 ++ drivers/hwmon/applesmc.c | 2 +- drivers/staging/speakup/spk_types.h | 2 +- include/linux/compiler-gcc.h | 1 + include/linux/compiler.h | 10 + include/linux/kernel.h | 13 ++ include/linux/smpboot.h | 2 +- include/linux/usb.h | 2 +- lib/test_printf.c | 41 ++++ lib/vsprintf.c | 63 +++++ scripts/Makefile.gcc-plugins | 2 + scripts/gcc-plugins/format_template_plugin.c | 331 +++++++++++++++++++++++++++ 12 files changed, 483 insertions(+), 4 deletions(-) create mode 100644 scripts/gcc-plugins/format_template_plugin.c -- 2.11.0