linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Ingo Molnar <mingo@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jiri Olsa <jolsa@kernel.org>, Andi Kleen <ak@linux.intel.com>
Subject: [PATCH] perf tools: Add reject option for parse-events.l
Date: Thu, 9 Nov 2017 09:17:49 +0100	[thread overview]
Message-ID: <20171109081749.GA21513@krava> (raw)

Reply-To: 
In-Reply-To: <20171109081319.GB236@x4>

On Thu, Nov 09, 2017 at 09:13:19AM +0100, Markus Trippelsdorf wrote:
> On 2017.11.05 at 15:40 +0100, Ingo Molnar wrote:
> > Linus,
> >
> > Please pull the latest perf-urgent-for-linus git tree from:
> >
> >    git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-urgent-for-linus
> >
> > Jiri Olsa (1):
> >       perf tools: Unwind properly location after REJECT
> 
> The patch above breaks the build for me:
> 
> util/parse-events.l: In function ‘parse_events_lex’:
> util/parse-events-flex.c:4722:16: error: ‘reject_used_but_not_detected’ undeclared (first use in this function)
>   */
>                 ^
> util/parse-events.l:159:2: note: in expansion of macro ‘REJECT’
>   REJECT
>   ^~~~~~
> util/parse-events.l:343:26: note: in expansion of macro ‘USER_REJECT’
>  {bpf_source}  { if (!isbpf(yyscanner)) USER_REJECT; return str(yyscanner, PE_BPF_SOURCE); }
>                           ^~~~~~~~~~~
> util/parse-events-flex.c:4722:16: note: each undeclared identifier is reported only once for each function it appears in
>   */
>                 ^
> util/parse-events.l:159:2: note: in expansion of macro ‘REJECT’
>   REJECT
>   ^~~~~~
> util/parse-events.l:343:26: note: in expansion of macro ‘USER_REJECT’
>  {bpf_source}  { if (!isbpf(yyscanner)) USER_REJECT; return str(yyscanner, PE_BPF_SOURCE); }
>                           ^~~~~~~~~~~
> mv: cannot stat 'util/.parse-events-flex.o.tmp': No such file or directory

sry, we have a fix in queue already

jitka


---
Arnaldo reported broken build under some distros due to
flex no spotting the REJECT macro:

  CC       /tmp/build/perf/util/parse-events-flex.o
  util/parse-events.l: In function 'parse_events_lex':
  /tmp/build/perf/util/parse-events-flex.c:4734:16: error: \
  'reject_used_but_not_detected' undeclared (first use in this function)

It's happening because we put the REJECT under another
USER_REJECT macro in following commit:
  9445464bb831 perf tools: Unwind properly location after REJECT

Fortunately flex provides option for force it to use REJECT,
adding it to parse-events.l.

Reported-by: Arnaldo Carvalho de Melo <acme@kernel.org>
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Link: http://lkml.kernel.org/n/tip-7kdont984mw12ijk7rji6b8p@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/util/parse-events.l | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
index bd3bba9a2e81..42d697423a3e 100644
--- a/tools/perf/util/parse-events.l
+++ b/tools/perf/util/parse-events.l
@@ -5,6 +5,7 @@
 %option stack
 %option bison-locations
 %option yylineno
+%option reject
 
 %{
 #include <errno.h>
-- 
2.13.6

             reply	other threads:[~2017-11-09  8:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09  8:17 Jiri Olsa [this message]
2017-11-09 13:22 ` [PATCH] perf tools: Add reject option for parse-events.l Arnaldo Carvalho de Melo
2017-11-09 13:27   ` Markus Trippelsdorf
2017-11-09 13:51     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171109081749.GA21513@krava \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).