From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752860AbdKIKmk (ORCPT ); Thu, 9 Nov 2017 05:42:40 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:51679 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbdKIKmi (ORCPT ); Thu, 9 Nov 2017 05:42:38 -0500 Date: Thu, 9 Nov 2017 11:42:37 +0100 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Kate Stewart , Philippe Ombredanne Subject: Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/ Message-ID: <20171109104236.GA10048@amd> References: <20171019083832.GA21820@kroah.com> <20171103102830.GA18343@kroah.com> <20171109095148.GC6074@amd> <20171109104028.GA13751@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline In-Reply-To: <20171109104028.GA13751@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2017-11-09 11:40:28, Greg Kroah-Hartman wrote: > On Thu, Nov 09, 2017 at 10:51:48AM +0100, Pavel Machek wrote: > > Hi! > >=20 > > > It's good to have SPDX identifiers in all files to make it easier to > > > audit the kernel tree for correct licenses. > > >=20 > > > Update the drivers/usb/ and include/linux/usb* files with the correct > > > SPDX license identifier based on the license text in the file itself. > > > The SPDX identifier is a legally binding shorthand, which can be used > > > instead of the full boiler plate text. > > >=20 > > > This work is based on a script and data from Thomas Gleixner, Philippe > > > Ombredanne, and Kate Stewart. > > >=20 > > > Cc: Thomas Gleixner > > > Cc: Kate Stewart > > > Cc: Philippe Ombredanne > > > Signed-off-by: Greg Kroah-Hartman > > > --- > > > v2: Use the "standard" format of putting the identifier at the top of > > > the file, and use // for .c and .h files. > > > Removed the files already marked in Linus's tree. > > >=20 > > > Unless someone really complains, I'm going to add this to my tree for > > > 4.15-rc1. > >=20 > > as you said in some other email... this stands out a bit too > > much. >=20 > That is the goal, sorry. Then it is bad goal. Automated tools can pick it up whereever it is. No need to grab attention with poor placing. > > What about using normal c comments, and put it near the original > > license text? It is not exactly the most important thing... > >=20 > > Or maybe near the MODULE_LICENSE, so the two don't get out of sync? >=20 > No, the top of the file is best, thanks. No, it is not, thanks. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAloEMRwACgkQMOfwapXb+vKA9gCfbT9pLE0KXegGqVIcs8d6MGQV ICIAoIh+KU24oMBjSJn4m0/E7gB2o6u8 =c13w -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW--