From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754475AbdKIMl4 (ORCPT ); Thu, 9 Nov 2017 07:41:56 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:46806 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbdKIMlx (ORCPT ); Thu, 9 Nov 2017 07:41:53 -0500 Date: Thu, 9 Nov 2017 12:41:43 +0000 From: Mark Brown To: "Andrew F. Davis" Cc: Liam Girdwood , Rob Herring , Mark Rutland , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/17] ASoC: tlv320aic31xx: General source formatting cleanup Message-ID: <20171109124143.mpolqcvsdzj2t6tv@sirena.co.uk> References: <20171109002741.10897-1-afd@ti.com> <20171109002741.10897-2-afd@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r2eiv4wnvkyqnbbj" Content-Disposition: inline In-Reply-To: <20171109002741.10897-2-afd@ti.com> X-Cookie: Your mileage may vary. User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --r2eiv4wnvkyqnbbj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 08, 2017 at 06:27:25PM -0600, Andrew F. Davis wrote: > Simple non-functional changes including: >=20 > * Fix header copyright tags > * Fix spelling errors > * Reformat code for easier reading > * Move some code blocks to a more natural ordering > * Remove unneeded code > * Remove assignments that are always overridden > * Normalize function return paths >=20 > Signed-off-by: Andrew F. Davis There's other things in here like adding error reporting... please don't send changes like this, if you want to do cleanups you should split them up in the same way you would other changes. Bigger patches are harder to review especially if they're not repetitive examples of the same pattern. =20 --r2eiv4wnvkyqnbbj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAloETQYACgkQJNaLcl1U h9Bj2wf/WSq0Nv2h3DBZSFu6PzUWpOsuarkxzYbINzKGIMVDzAtwuEfJLzTH/Tv6 J/qz+7DiEYjVdLQv7vO6hSMrIn+4WYyUDs/BcJ6SyNkhlOOmY84s2E2g0WdgTi1D glTZsqkeliT1qfN+N3fqkCGwIoZi3+LuGhNF1BoSpfyExOvAYHoPLuyRWcc9M4rm wo9wDqweQTq8SdP1QY0gdpGFsae+UHRdCLgrQqz3BN25PayXseIbBYvex1aYzVJf xv+bvxVj+5LohZzh2V/8T/7ZlC27UQmpmgegE0K7ecbhC9UerFb8t6BsTGfIfg7U gvxW/fbmisFwSIw1SStXmMyCZ5AYvQ== =E1YO -----END PGP SIGNATURE----- --r2eiv4wnvkyqnbbj--