From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Hyunchul Lee <hyc.lee@gmail.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-team@lge.com, Hyunchul Lee <cheol.lee@lge.com>
Subject: Re: [RFC PATHC 1/2] f2fs: apply write hints to select the type of segments for buffered write
Date: Thu, 9 Nov 2017 10:19:05 -0800 [thread overview]
Message-ID: <20171109181905.GB59398@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <89790335-1d07-9280-ef17-1bdaeaafb54b@huawei.com>
On 11/09, Chao Yu wrote:
> On 2017/11/9 13:51, Hyunchul Lee wrote:
> > From: Hyunchul Lee <cheol.lee@lge.com>
> >
> > Write hints helps F2FS to determine which type of segments would be
> > selected for buffered write.
> >
> > This patch implements the mapping from write hints to segment types
> > as shown below.
> >
> > hints segment type
> > ----- ------------
> > WRITE_LIFE_SHORT CURSEG_COLD_DATA
> > WRITE_LIFE_EXTREME CURSEG_HOT_DATA
>
> Should keep consistent with code implementation.
Merged with this fix. ;)
>
> WRITE_LIFE_SHORT CURSEG_HOT_DATA
> WRITE_LIFE_EXTREME CURSEG_COLD_DATA
>
> > others CURSEG_WARM_DATA
> >
> > the F2FS poliy for hot/cold seperation has precedence over this hints.
> > And hints are not applied in in-place update.
> >
> > Signed-off-by: Hyunchul Lee <cheol.lee@lge.com>
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>
> Thanks,
>
> > ---
> > fs/f2fs/segment.c | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> > index c695ff4..45aef53 100644
> > --- a/fs/f2fs/segment.c
> > +++ b/fs/f2fs/segment.c
> > @@ -2258,6 +2258,18 @@ static bool __has_curseg_space(struct f2fs_sb_info *sbi, int type)
> > return false;
> > }
> >
> > +int rw_hint_to_seg_type(enum rw_hint hint)
> > +{
> > + switch (hint) {
> > + case WRITE_LIFE_SHORT:
> > + return CURSEG_HOT_DATA;
> > + case WRITE_LIFE_EXTREME:
> > + return CURSEG_COLD_DATA;
> > + default:
> > + return CURSEG_WARM_DATA;
> > + }
> > +}
> > +
> > static int __get_segment_type_2(struct f2fs_io_info *fio)
> > {
> > if (fio->type == DATA)
> > @@ -2292,7 +2304,7 @@ static int __get_segment_type_6(struct f2fs_io_info *fio)
> > return CURSEG_COLD_DATA;
> > if (is_inode_flag_set(inode, FI_HOT_DATA))
> > return CURSEG_HOT_DATA;
> > - return CURSEG_WARM_DATA;
> > + return rw_hint_to_seg_type(inode->i_write_hint);
> > } else {
> > if (IS_DNODE(fio->page))
> > return is_cold_node(fio->page) ? CURSEG_WARM_NODE :
> >
next prev parent reply other threads:[~2017-11-09 18:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 5:51 [RFC PATCH 0/2] apply write hints to select the type of segments Hyunchul Lee
2017-11-09 5:51 ` [RFC PATHC 1/2] f2fs: apply write hints to select the type of segments for buffered write Hyunchul Lee
2017-11-09 8:21 ` Chao Yu
2017-11-09 18:19 ` Jaegeuk Kim [this message]
2017-11-09 5:51 ` [RFC PATHC 2/2] f2fs: apply write hints to select the type of segment for direct write Hyunchul Lee
2017-11-11 0:38 ` [f2fs-dev] " Chao Yu
2017-11-13 0:07 ` Hyunchul Lee
2017-11-13 1:24 ` Chao Yu
2017-11-13 1:48 ` Hyunchul Lee
2017-11-09 9:12 ` [RFC PATCH 0/2] apply write hints to select the type of segments Chao Yu
2017-11-09 18:16 ` Jaegeuk Kim
2017-11-10 2:31 ` Chao Yu
2017-11-10 0:23 ` Hyunchul Lee
2017-11-10 6:42 ` Chao Yu
2017-11-13 0:24 ` Hyunchul Lee
2017-11-13 1:26 ` Chao Yu
2017-11-13 1:35 ` Hyunchul Lee
2017-11-13 1:59 ` Chao Yu
2017-11-13 2:25 ` Hyunchul Lee
2017-11-14 4:20 ` Jaegeuk Kim
2017-11-14 6:22 ` Chao Yu
2017-11-15 16:27 ` Jaegeuk Kim
2017-11-16 0:56 ` Hyunchul Lee
2017-11-16 2:52 ` Chao Yu
2017-11-16 3:58 ` Jaegeuk Kim
2017-11-16 4:35 ` Hyunchul Lee
2017-11-17 18:53 ` Jaegeuk Kim
2017-11-20 2:12 ` Hyunchul Lee
2017-11-17 17:23 ` Christoph Hellwig
2017-11-17 18:36 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109181905.GB59398@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=cheol.lee@lge.com \
--cc=hyc.lee@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).